From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36183)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W6KOv-0002OW-K2
	for qemu-devel@nongnu.org; Thu, 23 Jan 2014 08:33:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W6KOp-0004ai-G8
	for qemu-devel@nongnu.org; Thu, 23 Jan 2014 08:32:57 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39126 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W6KOp-0004aa-9s
	for qemu-devel@nongnu.org; Thu, 23 Jan 2014 08:32:51 -0500
Message-ID: <52E11A00.3060109@suse.de>
Date: Thu, 23 Jan 2014 14:32:48 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1384273995-16486-1-git-send-email-cminyard@mvista.com>
	<1384273995-16486-2-git-send-email-cminyard@mvista.com>
In-Reply-To: <1384273995-16486-2-git-send-email-cminyard@mvista.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/16] qemu-char: Allocate CharDriverState
 in qemu_chr_new_from_opts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Minyard <minyard@acm.org>, qemu-devel@nongnu.org
Cc: Bret Ketchum <bcketchum@gmail.com>, Corey Minyard <cminyard@mvista.com>, "Michael S. Tsirkin" <mst@redhat.com>

Am 12.11.2013 17:33, schrieb Corey Minyard:
> This allocates the CharDriverState structure and passes it in to the
> open routine.  This allows a coming option to automatically attempt to
> reconnect a chardev if the connection fails.  The chardev has to be
> kept around so a reconnect can be done on it.
>=20
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
[...]
> diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h
> index 86c75c7..eadb9c9 100644
> --- a/include/ui/qemu-spice.h
> +++ b/include/ui/qemu-spice.h
> @@ -46,9 +46,11 @@ int qemu_spice_migrate_info(const char *hostname, in=
t port, int tls_port,
>  void do_info_spice_print(Monitor *mon, const QObject *data);
>  void do_info_spice(Monitor *mon, QObject **ret_data);
> =20
> -CharDriverState *qemu_chr_open_spice_vmc(const char *type);
> +CharDriverState *qemu_chr_open_spice_vmc(CharDriverState *chr,
> +                                         const char *type);
>  #if SPICE_SERVER_VERSION >=3D 0x000c02
> -CharDriverState *qemu_chr_open_spice_port(const char *name);
> +CharDriverState *qemu_chr_open_spice_port(CharDriverSTate *chr,

This needs to be CharDriverState.

> +                                          const char *name);
>  void qemu_spice_register_ports(void);
>  #else
>  static inline CharDriverState *qemu_chr_open_spice_port(const char *na=
me)
[snip]

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg