From: Tomasz Figa <t.figa@samsung.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Kgene Kim <kgene.kim@samsung.com>, Arnd Bergmann <arnd@arndb.de>,
Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH] ARM: dts: Add l2x0 device node for Exynos4-based boards
Date: Fri, 24 Jan 2014 12:48:13 +0100 [thread overview]
Message-ID: <52E252FD.7030908@samsung.com> (raw)
In-Reply-To: <CAHbNUh3=RVj-40d++Qa9OORBS53==zKr6XKYhEKoDYLudwFoSg@mail.gmail.com>
On 24.01.2014 05:44, Tushar Behera wrote:
> On 23 January 2014 23:45, Tomasz Figa <t.figa@samsung.com> wrote:
>> Hi,
>>
>>
>> On 07.01.2014 09:53, Tushar Behera wrote:
>>>
>>> For Exynos4 platform, L2 cache initialization is done only if
>>> a device node for l2x0 device exists.
>>>
>>> L2 cache initialization path is different when a board boots with
>>> secure firmware. Since there are many Exynos4 based SoCs that boot
>>> in secure mode, enabling this only for boards that don't boot with
>>> secure firmware.
>>>
>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>> ---
>>>
>>> Tested on Exynos4210-Origen board.
>>>
>>> arch/arm/boot/dts/exynos4.dtsi | 8 ++++++++
>>> arch/arm/boot/dts/exynos4210-origen.dts | 4 ++++
>>> arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 ++++
>>> arch/arm/boot/dts/exynos4210-trats.dts | 4 ++++
>>> arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
>>> arch/arm/boot/dts/exynos4412-odroidx.dts | 4 ++++
>>> arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++++
>>> arch/arm/boot/dts/exynos4412-tiny4412.dts | 4 ++++
>>> 8 files changed, 36 insertions(+)
>>
>>
>> Looks good. Unfortunately this is still going to break secure firmware
>> enabled boards, because l2x0_of_init() does not check if the node is
>> enabled.
>>
>
> Is the following check in l2x0_of_init() not enough?
>
> 1002 |-------np = of_find_matching_node(NULL, l2x0_ids);
> 1003 |-------if (!np)
> 1004 |-------|-------return -ENODEV;
It only looks for a matching node without checking its status property.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-01-24 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 8:53 [PATCH] ARM: dts: Add l2x0 device node for Exynos4-based boards Tushar Behera
2014-01-23 18:15 ` Tomasz Figa
2014-01-24 4:44 ` Tushar Behera
2014-01-24 11:48 ` Tomasz Figa [this message]
2014-02-12 9:33 ` Tushar Behera
2014-02-12 10:10 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E252FD.7030908@samsung.com \
--to=t.figa@samsung.com \
--cc=arnd@arndb.de \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.