From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Eremin-Solenikov Subject: Re: [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Date: Fri, 24 Jan 2014 19:25:19 +0400 Message-ID: <52E285DF.5020708@gmail.com> References: <1390411194-21410-1-git-send-email-jenny.tc@intel.com> <1390411194-21410-2-git-send-email-jenny.tc@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1390411194-21410-2-git-send-email-jenny.tc@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jenny TC Cc: linux-kernel@vger.kernel.org, Kim Milo , Lee Jones , Jingoo Han , Chanwoo Choi , Sachin Kamat , Rupesh Kumar , Lars-Peter Clausen , =?ISO-8859-1?Q?Pali_Roh=E1r?= , Mark Brown , Rhyland Klein , Pavel Machek , David Woodhouse , Tony Lindgren , Russell King , Sebastian Reichel , aaro.koskinen@iki.fi, freemangordon@abv.bg, linux-omap@vger.kernel.org, Anton Vorontsov List-Id: linux-omap@vger.kernel.org On 22/01/14 21:19, Jenny TC wrote: > Add new power supply properties for input current, charge termination > current, min and max temperature > > POWER_SUPPLY_PROP_TEMP_MIN - minimum operatable temperature > POWER_SUPPLY_PROP_TEMP_MAX - maximum operatable temperature What is the difference from TEMP_ALERT_MIN/TEMP_ALERT_MAX ? There is a difference in definitions, but what is the logical difference? > POWER_SUPPLY_PROP_INLMT - input current limit programmed by charger. Indicates > the input current for a charging source. > POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect > the end of charge condition For both of them: 1) Please don't use obscure abbreviations 2) Is this generic enough? I.e. besides your charge manager who will use that? -- With best wishes Dmitry