Re: next boot: 34 pass, 5 fail (next-20140122)

[Florian Vaussard <florian.vaussard@epfl.ch>]

Hi,

On 01/24/2014 07:11 PM, Tony Lindgren wrote:
> * Florian Vaussard <florian.vaussard@epfl.ch> [140123 01:17]:
>>
>> I just tested next-20140123 with an OMAP3630 ES1.2 Overo/Tobi. Changing
>> the include to omap36xx.dtsi do not fix the issue. I still get the
>> external abort on non-linefetch (full log here [1]).
> 
> I think the issue here is that you need to have "ti,omap36xx" in
> the compatible string in addition to including omap36xx.dtsi.
> Otherwise "ti,omap3" will initialize things for 34xx.
> 
> For the initial minimal fix, I suggest we do something like the
> following. This should fix things for 36xx based tobi, then
> 34xx based tobi support can be added later on. Untested as I
> don't have one.
> 

You are probably right. I will test Monday.

Regards,

Florian

> Regards,
> 
> Tony
> 
> 
> --- a/arch/arm/boot/dts/omap3-overo.dtsi
> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
> @@ -9,9 +9,6 @@
>  /*
>   * The Gumstix Overo must be combined with an expansion board.
>   */
> -/dts-v1/;
> -
> -#include "omap34xx.dtsi"
>  
>  / {
>  	pwmleds {
> --- a/arch/arm/boot/dts/omap3-tobi.dts
> +++ b/arch/arm/boot/dts/omap3-tobi.dts
> @@ -10,11 +10,14 @@
>   * Tobi expansion board is manufactured by Gumstix Inc.
>   */
>  
> +/dts-v1/;
> +
> +#include "omap36xx.dtsi"
>  #include "omap3-overo.dtsi"
>  
>  / {
>  	model = "TI OMAP3 Gumstix Overo on Tobi";
> -	compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3";
> +	compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap36xx", "ti,omap3";
>  
>  	leds {
>  		compatible = "gpio-leds";
>