From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Nikolay Aleksandrov <nikolay@redhat.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Veaceslav Falico <vfalico@redhat.com>,
Andy Gospodarek <andy@greyhouse.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers
Date: Fri, 24 Jan 2014 18:27:36 +0000 [thread overview]
Message-ID: <52E2B098.1060509@citrix.com> (raw)
In-Reply-To: <52E18720.4060008@redhat.com>
On 23/01/14 21:18, Nikolay Aleksandrov wrote:
>> Hi Zoltan,
>> Thanks for fixing this, a few comments though:
>> bond->params.miimon can be 0 here that's why there's a check afterwards,
>> also please separate the local variable definitions from the body with a
>> new line.
>> The same applies for downdelay.
>>
>> Nik
> In fact since we don't need the u64 and newval->value is limited to
> INT_MAX, can't we simply cast it to (int) and avoid the do_div entirely ?
Yep, that's even better, thanks for fixing it!
Zoli
next prev parent reply other threads:[~2014-01-24 18:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 18:47 [PATCH net-next] bonding: Use do_div to divide 64 bit numbers Zoltan Kiss
2014-01-23 20:44 ` Nikolay Aleksandrov
2014-01-23 21:18 ` Nikolay Aleksandrov
2014-01-23 22:43 ` [PATCH net-next] bonding: fix u64 division Nikolay Aleksandrov
2014-01-24 0:12 ` David Miller
2014-01-24 18:27 ` Zoltan Kiss [this message]
2014-01-23 22:25 ` [PATCH net-next] bonding: Use do_div to divide 64 bit numbers Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E2B098.1060509@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.