From: Kenneth Graunke <kenneth@whitecape.org>
To: Ben Widawsky <benjamin.widawsky@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM
Date: Sat, 25 Jan 2014 00:32:33 -0800 [thread overview]
Message-ID: <52E376A1.8000803@whitecape.org> (raw)
In-Reply-To: <1390616265-4329-1-git-send-email-benjamin.widawsky@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1261 bytes --]
On 01/24/2014 06:17 PM, Ben Widawsky wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> This is useful for debugging as we then know that the first entry is
> always the global GTT, and all later entries the per-process GTT VM.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 024e454..946a577 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4634,7 +4634,7 @@ void i915_init_vm(struct drm_i915_private *dev_priv,
> INIT_LIST_HEAD(&vm->active_list);
> INIT_LIST_HEAD(&vm->inactive_list);
> INIT_LIST_HEAD(&vm->global_link);
> - list_add(&vm->global_link, &dev_priv->vm_list);
> + list_add_tail(&vm->global_link, &dev_priv->vm_list);
> }
>
> void
These five patches are:
Tested-by: Kenneth Graunke <kenneth@whitecape.org>
On Broadwell with drm-intel-nightly, I don't get the batchbuffer as part
of my error state, which is a regression. With these patches, it's back
again.
Thanks for investigating this, Ben.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-01-25 8:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 2:17 [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM Ben Widawsky
2014-01-25 2:17 ` [PATCH 2/5] drm/i915: Print captured bo for all VM in error state Ben Widawsky
2014-01-25 2:17 ` [PATCH 3/5] drm/i915: Create a USES_PPGTT macro Ben Widawsky
2014-01-25 20:41 ` Daniel Vetter
2014-01-26 5:45 ` Ben Widawsky
2014-01-26 9:24 ` Daniel Vetter
2014-01-25 2:17 ` [PATCH 4/5] drm/i915: Capture PPGTT info on error capture Ben Widawsky
2014-01-26 11:42 ` Chris Wilson
2014-01-26 19:06 ` Ben Widawsky
2014-01-26 19:51 ` Chris Wilson
2014-01-25 2:17 ` [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW Ben Widawsky
2014-01-26 11:47 ` Chris Wilson
2014-01-26 19:05 ` Ben Widawsky
2014-01-26 19:55 ` Chris Wilson
2014-01-26 21:47 ` Ben Widawsky
2014-01-27 13:45 ` Chris Wilson
2014-01-27 18:24 ` Ben Widawsky
2014-01-27 20:31 ` Ben Widawsky
2014-01-27 21:31 ` Chris Wilson
2014-01-27 21:54 ` Ben Widawsky
2014-01-25 8:32 ` Kenneth Graunke [this message]
2014-01-25 20:48 ` [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM Daniel Vetter
2014-01-25 21:31 ` Kenneth Graunke
2014-01-26 5:09 ` Ben Widawsky
2014-01-26 9:26 ` Daniel Vetter
2014-01-26 11:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E376A1.8000803@whitecape.org \
--to=kenneth@whitecape.org \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.