Re: [linux-sunxi] Firmware for Bluetooth (and wifi)

[Arend van Spriel <arend@broadcom.com>]

On 01/26/2014 01:09 PM, Hans de Goede wrote:
> Hi,
> 
> On 01/26/2014 12:04 PM, Arend van Spriel wrote:
>> On 01/24/2014 05:34 PM, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 01/24/2014 11:25 AM, Arend van Spriel wrote:
>>>> On 01/23/2014 11:39 PM, Hans de Goede wrote:
>>>>> Hi,
>>>>>
>>>>> I've been working on updating sunxi-devel to include more
>>>>> recent versions if your gmac patches, as well as adding support
>>>>> for the wifi + bluetooth found on the cubietruck.
>>>>>
>>>>> Here is my current work on this:
>>>>>
>>>>> https://github.com/jwrdegoede/linux-sunxi/commits/sunxi-devel
>>>>>
>>>>> It is close to working, but unfortunately it does not work,
>>>>> here is what I get in dmesg when I modprove the module:
>>>>>
>>>>> [   99.700889] brcmfmac_sdio mmc1:0001:1: device tree node not found
>>>>> [  100.020984] brcmfmac: brcmf_c_preinit_dcmds: Firmware version =
>>>>> wl0:
>>>>> Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01-b30a427d
>>>>> [  100.260948] brcmfmac: brcmf_fil_cmd_data: Failed err=-23
>>>>> [  100.281260] brcmfmac: brcmf_fil_cmd_data: Failed err=-23
>>>>> [  100.322508] usbcore: registered new interface driver brcmfmac
>>>>> [  160.445215] brcmfmac: brcmf_cfg80211_sched_scan_start: Scanning
>>>>> already: status (1)
>>>>> [  203.445404] brcmfmac: brcmf_cfg80211_sched_scan_start: Scanning
>>>>> already: status (1)
>>>>> [  256.445140] brcmfmac: brcmf_cfg80211_sched_scan_start: Scanning
>>>>> already: status (1)
>>>>
>>>> Can you enable debug logging in brcmfmac, ie. debug=0xd416 so I can
>>>> have
>>>> a look.
>>>
>>> I've captured a log with these flags until the first "Scanning already"
>>> message, you can find it here:
>>
>> Hi Hans,
>>
>> The log looks confusing.
>>
>> [  543.512827] brcmfmac: brcmf_fweh_event_worker event ESCAN_RESULT (69)
>> ifidx 0 bsscfg 0 addr 02:00:00:00:00:00
>> [  543.512840] brcmfmac: brcmf_fweh_event_worker   version 2 flags 0
>> status 0 reason 0
>> [  543.512849] brcmutil: event payload, len=12
>> [  543.512860] 00000000: 0c 00 00 00 6d 00 00 00 34 12 00 00
>>    ....m...4...
>> [  543.512872] brcmfmac: brcmf_inform_bss scanned AP count (0)
>> [  543.512880] brcmfmac: brcmf_notify_escan_complete Enter
>> [  543.512891] brcmfmac: brcmf_notify_escan_complete ESCAN Completed
>> scan: Done
>> [  543.512911] brcmfmac: brcmf_fil_iovar_data_set name=mpc, len=4
>> [  543.512919] brcmutil: data
>> [  543.512928] 00000000: 01 00 00 00
>>    ....
>> [  543.512941] brcmfmac: brcmf_sdbrcm_bus_txctl Enter
>> [  543.512951] brcmfmac: brcmf_sdbrcm_bus_sleep Enter
>> [  543.513018] brcmfmac: brcmf_sdbrcm_bus_rxctl Enter
>>
>> The trace messages above indicate completion of regular scan and after
>> that the code does:
>>
>>     if (!test_and_clear_bit(BRCMF_SCAN_STATUS_BUSY, &cfg->scan_status))
>>         brcmf_dbg(SCAN, "Scan complete, probably P2P scan\n");
>>
>> [  543.514758] brcmfmac: brcmf_cfg80211_sched_scan_start Enter
>> n_match_sets:0 n_ssids:0
>> [  543.514777] brcmfmac: brcmf_cfg80211_sched_scan_start: Scanning
>> already: status (1)
>>
>> So the bit SCAN_STATUS_BUSY should be cleared, but you get this message.
>> That makes no sense to me or test_and_clear_bit() does something else
>> than I expect.
> 
> Once I've successfully associated these messages go away, so it is
> possible that this is a bug which has been around for a while, but people
> normally never see because the code path is not entered.
> 
> Or could it be that this bug gets triggered by the regular scan turning
> up with 0 access points, maybe that causes it to enter a path where it
> does not clear the bit in question ?

I think that is partly true or some trace messages were missing, but I
think the trigger is the 0 APs. Thanks for letting me know.

Regards,
Arend