All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: Wang Shilong <wangshilong1991@gmail.com>, <linux-btrfs@vger.kernel.org>
Cc: Wang Shilong <wangsl.fnst@cn.fujitsu.com>,
	Liu Bo <bo.li.liu@oracle.com>, Zach Brown <zab@redhat.com>
Subject: Re: [PATCH RFC v2 1/2] Btrfs: rework ulist with list+rb_tree
Date: Sun, 26 Jan 2014 13:18:04 -0500	[thread overview]
Message-ID: <52E5515C.20907@fb.com> (raw)
In-Reply-To: <1390633178-2104-1-git-send-email-wangshilong1991@gmail.com>


On 01/25/2014 01:59 AM, Wang Shilong wrote:
> From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
>
> We are really suffering from now ulist's implementation, some developers
> gave their try, and i just gave some of my ideas for things:
>
>   1. use list+rb_tree instead of arrary+rb_tree
>
>   2. add cur_list to iterator rather than ulist structure.
>
>   3. add seqnum into every node when they are added, this is
>   used to do selfcheck when iterating node.
>
> I noticed Zach Brown's comments before, long term is to kick off
> ulist implementation, however, for now, we need at least avoid
> arrary from ulist.
>
> Cc: Liu Bo <bo.li.liu@oracle.com>
> Cc: Josef Bacik <jbacik@fb.com>
> Cc: Zach Brown <zab@redhat.com>
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> ---

I like it, can we use CONFIG_BTRFS_DEBUG or whatever it's called for the 
seqnum check to make the struct a bit smaller in the normal case?  Thanks,

Josef

      parent reply	other threads:[~2014-01-26 18:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-25  6:59 [PATCH RFC v2 1/2] Btrfs: rework ulist with list+rb_tree Wang Shilong
2014-01-25  6:59 ` [PATCH v2 2/2] Btrfs: do not export ulist functions Wang Shilong
2014-01-26 18:18 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E5515C.20907@fb.com \
    --to=jbacik@fb.com \
    --cc=bo.li.liu@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wangshilong1991@gmail.com \
    --cc=wangsl.fnst@cn.fujitsu.com \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.