From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Prefer 'command -v' over 'which' (for portability)
Date: Mon, 27 Jan 2014 08:20:00 +0100 [thread overview]
Message-ID: <52E608A0.3000305@mind.be> (raw)
In-Reply-To: <1390659116-18865-1-git-send-email-bjorn.forsman@gmail.com>
On 25/01/14 15:11, Bj?rn Forsman wrote:
> 'command -v' is defined by POSIX (and is available "everywhere"),
> 'which' is not.
>
> This is improves user experience when 'which' isn't installed so that
> there won't be error messages about missing 'which'*before* the
> Buildroot dependency check is run.
>
> Current behaviour:
>
> $ make
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> /bin/sh: which: command not found
> support/dependencies/check-host-tar.sh: line 5: which: command not found
> support/dependencies/check-host-tar.sh: line 7: which: command not found
> /home/bfo/buildroot/support/dependencies/dependencies.sh: line 56:
> which: command not found
>
> You must install 'which' on your build machine
> make: *** [core-dependencies] Error 1
>
> New behaviour:
>
> $ make
>
> You must install 'which' on your build machine
> make: *** [core-dependencies] Error 1
>
> Signed-off-by: Bj?rn Forsman<bjorn.forsman@gmail.com>
There are also instances of which in manual.mk and toolchain-external.mk.
With those removed, I wonder if it is even necessary to have which
installed at all? Could you test that with a largish config?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-01-27 7:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 14:11 [Buildroot] [PATCH 1/1] Prefer 'command -v' over 'which' (for portability) Bjørn Forsman
2014-01-27 6:44 ` Thomas Petazzoni
2014-01-27 19:47 ` Bjørn Forsman
2014-01-27 7:20 ` Arnout Vandecappelle [this message]
2014-01-27 20:13 ` Bjørn Forsman
2014-01-27 22:23 ` Bjørn Forsman
2014-01-27 9:19 ` Samuel Martin
2014-01-27 20:01 ` Bjørn Forsman
2014-01-27 20:32 ` Thomas De Schampheleire
2014-01-27 21:09 ` Bjørn Forsman
2014-01-28 6:54 ` Arnout Vandecappelle
2014-02-15 11:44 ` Yann E. MORIN
2014-02-15 13:29 ` Bjørn Forsman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E608A0.3000305@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.