From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7jDq-0002hW-9k for qemu-devel@nongnu.org; Mon, 27 Jan 2014 05:15:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7jDk-0001uR-8C for qemu-devel@nongnu.org; Mon, 27 Jan 2014 05:15:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7jDk-0001tr-1I for qemu-devel@nongnu.org; Mon, 27 Jan 2014 05:15:12 -0500 Message-ID: <52E631A4.20408@redhat.com> Date: Mon, 27 Jan 2014 11:15:00 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1390488396-16538-1-git-send-email-akong@redhat.com> <1390488396-16538-5-git-send-email-akong@redhat.com> <20140124104831.GA11239@T430.nay.redhat.com> <20140127081756.GB2572@amosk.info> <52E62910.5050303@redhat.com> <20140127100724.GC20568@amosk.info> In-Reply-To: <20140127100724.GC20568@amosk.info> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: qemu-devel@nongnu.org, Fam Zheng , libvir-list@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, qiaonuohan@cn.fujitsu.com, xiawenc@linux.vnet.ibm.com Il 27/01/2014 11:07, Amos Kong ha scritto: >> > No, I don't like this. >> > >> > QAPI types are perfectly able to "describe themselves", there is no >> > need to escape to JSON. >> > >> > Let's just do what this series is doing, minus the unnecessary recursion. > > The recursion extend was requested by Libvirt, they want to get a > extended output with metadata to avoid heavy parsing in Libvirt. > > Let's see the response of libvirt people. > I think Eric already answered. In any case, 4 seconds to produce 1.7 MB is a sign of a bug in my opinion. What does the profile say? Paolo