From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f47.google.com ([209.85.215.47]:54608 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753811AbaA0Msb (ORCPT ); Mon, 27 Jan 2014 07:48:31 -0500 Received: by mail-la0-f47.google.com with SMTP id hr17so4453758lab.34 for ; Mon, 27 Jan 2014 04:48:30 -0800 (PST) Message-ID: <52E6559D.6090708@cogentembedded.com> Date: Mon, 27 Jan 2014 16:48:29 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Ben Dooks , linux-kernel@lists.codethink.co.uk CC: Bjorn Helgaas , Simon Horman , linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/8] pci-rcar-gen2: add of match table References: <1390754945-28142-1-git-send-email-ben.dooks@codethink.co.uk> <1390754945-28142-2-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: <1390754945-28142-2-git-send-email-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: Hello. On 26-01-2014 20:48, Ben Dooks wrote: > Add OF match table for pci-rcar-gen2 driver for device tree support. > Signed-off-by: Ben Dooks > --- > Cc: Bjorn Helgaas > Cc: Simon Horman > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c > index ceec147..ea65bac 100644 > --- a/drivers/pci/host/pci-rcar-gen2.c > +++ b/drivers/pci/host/pci-rcar-gen2.c > @@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct platform_device *pdev) > return rcar_pci_add_controller(priv); > } > > +static struct of_device_id rcar_pci_of_match[] = { > + { .compatible = "renesas,pci-r8a7790", }, Why only H2 SoC, if the driver is for both Gen2 SoCs? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 27 Jan 2014 12:48:29 +0000 Subject: Re: [PATCH 1/8] pci-rcar-gen2: add of match table Message-Id: <52E6559D.6090708@cogentembedded.com> List-Id: References: <1390754945-28142-1-git-send-email-ben.dooks@codethink.co.uk> <1390754945-28142-2-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: <1390754945-28142-2-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ben Dooks , linux-kernel@lists.codethink.co.uk Cc: Bjorn Helgaas , Simon Horman , linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org Hello. On 26-01-2014 20:48, Ben Dooks wrote: > Add OF match table for pci-rcar-gen2 driver for device tree support. > Signed-off-by: Ben Dooks > --- > Cc: Bjorn Helgaas > Cc: Simon Horman > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c > index ceec147..ea65bac 100644 > --- a/drivers/pci/host/pci-rcar-gen2.c > +++ b/drivers/pci/host/pci-rcar-gen2.c > @@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct platform_device *pdev) > return rcar_pci_add_controller(priv); > } > > +static struct of_device_id rcar_pci_of_match[] = { > + { .compatible = "renesas,pci-r8a7790", }, Why only H2 SoC, if the driver is for both Gen2 SoCs? WBR, Sergei