From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 27 Jan 2014 09:53:19 -0700 Subject: [U-Boot] [PATCH V3 01/14] mmc: tegra: support Tegra124 In-Reply-To: References: <1390592779-4395-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <52E68EFF.3090203@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/26/2014 09:11 AM, Simon Glass wrote: > Hi Stephen, > > On 24 January 2014 12:46, Stephen Warren > wrote: > > From: Stephen Warren > > > Tegra124's MMC controller is very similar to earlier SoC generations, > and can be supported by the same driver. > > However, there are some non-backwards-compatible HW differences, and > hence a new DT compatible value must be used to describe the HW. This > patch updates the driver to support that new compatible value. > > That said, the HW differences are only relevant when enabling certain > high-performance transfer modes. Since the driver is currently very > simple and doesn't enable those modes, we don't actually need to address > any of these HW differences in the code yet, hence the simple nature of > this patch. > > Signed-off-by: Stephen Warren > > Acked-by: Pantelis Antoniou > > Tested-by: Thierry Reding > > > > As a general comment on this series (not this patch) there is is > distressing amount of code duplication. It seems to me that this is just > going to get more and more painful unless it is addressed. Removing and > refactoring duplicated code is a difficult task. In particular defining > almost identical clock functions in multiple files just doesn't seem > like a good idea. Granted this is true. I am in the process of filing a bug to de-duplicate the drivers. > Other than that this series looks good to me. Thanks. Is that an ack? :-)