From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] minios: Correct HYPERVISOR_physdev_op()
Date: Mon, 27 Jan 2014 17:20:44 +0000
Message-ID: <52E6956C.6060100@citrix.com>
References: <1390588091-17670-1-git-send-email-andrew.cooper3@citrix.com>
	<1390843126.12230.46.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1390843126.12230.46.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 27/01/14 17:18, Ian Campbell wrote:
> On Fri, 2014-01-24 at 18:28 +0000, Andrew Cooper wrote:
>> A physdev_op is a two argument hypercall, taking a command paramter and an
>> optional pointer to a structure.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> CC: Samuel Thibault <samuel.thibault@ens-lyon.org>
> This hypercall is unused in minios and stubdoms I think? (Trying to
> gauge how critical the error is).

Correct.  I suppose it is more of a "nice to fix" than "must fix" at
this stage, although I was quite surprised that I needed to fix it.

~Andrew

>
>> ---
>>  extras/mini-os/include/x86/x86_32/hypercall-x86_32.h |    4 ++--
>>  extras/mini-os/include/x86/x86_64/hypercall-x86_64.h |    4 ++--
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h b/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
>> index ef52ecd..dcfbe41 100644
>> --- a/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
>> +++ b/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
>> @@ -255,9 +255,9 @@ HYPERVISOR_console_io(
>>  
>>  static inline int
>>  HYPERVISOR_physdev_op(
>> -	void *physdev_op)
>> +	int cmd, void *physdev_op)
>>  {
>> -	return _hypercall1(int, physdev_op, physdev_op);
>> +	return _hypercall2(int, physdev_op, cmd, physdev_op);
>>  }
>>  
>>  static inline int
>> diff --git a/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h b/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
>> index 513d74e..7083763 100644
>> --- a/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
>> +++ b/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
>> @@ -256,9 +256,9 @@ HYPERVISOR_console_io(
>>  
>>  static inline int
>>  HYPERVISOR_physdev_op(
>> -	void *physdev_op)
>> +	int cmd, void *physdev_op)
>>  {
>> -	return _hypercall1(int, physdev_op, physdev_op);
>> +	return _hypercall2(int, physdev_op, cmd, physdev_op);
>>  }
>>  
>>  static inline int
>