All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uboot-tools: Allow users to use uboot's sources
Date: Mon, 27 Jan 2014 18:34:16 +0100	[thread overview]
Message-ID: <52E69898.2080805@mind.be> (raw)
In-Reply-To: <52E5816F.9080102@lucaceresoli.net>

On 26/01/14 22:43, Luca Ceresoli wrote:
> Going a step ahead, to be more uniform with these packages, you may use
> a choice construct to allow choosing between two alternatives.
> Example (modified version of the code in barebox.mk):
>
> choice
>          prompt "version"
>          help
>            Select the specific uboot-tools version you want to use
>
> config BR2_PACKAGE_UBOOT_TOOLS_LATEST_VERSION
>          bool "Use a recent upstream version"
>
> config BR2_PACKAGE_UBOOT_TOOLS_USE_UBOOT_VERSION
>          bool "Use the same sources of the uboot package"
>
> endchoice

  Actually, I don't even see the need to ask the user anything. If we are 
building U-Boot, I don't see why we would ever want to use the U-Boot 
tools from upstream - that just adds a risk of incompatibility between 
the two.

  So I would propose to remove the BR2_PACKAGE_UBOOT_TOOLS_UBOOT_SOURCE 
option, and instead make it conditional on BR2_TARGET_UBOOT.


  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-01-27 17:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-26  0:35 [Buildroot] [PATCH] uboot-tools: Allow users to use uboot's sources Maxime Hadjinlian
2014-01-26 15:59 ` Luca Ceresoli
2014-01-26 16:31   ` Maxime Hadjinlian
2014-01-26 21:43     ` Luca Ceresoli
2014-01-27 17:34       ` Arnout Vandecappelle [this message]
2014-01-27 22:26         ` Luca Ceresoli
2014-01-28  6:02         ` Thomas De Schampheleire
2014-01-28  8:17           ` Maxime Hadjinlian
2014-01-28 10:55           ` Luca Ceresoli
2014-01-28 16:58           ` Arnout Vandecappelle
2014-01-28 22:10           ` Thomas Petazzoni
2014-01-27 17:45 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E69898.2080805@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.