All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/5] fs: implement infra-structure for an 'exists' function
Date: Mon, 27 Jan 2014 13:51:24 -0700	[thread overview]
Message-ID: <52E6C6CC.7000604@wwwdotorg.org> (raw)
In-Reply-To: <20140126194435.C45DB380ADF@gemini.denx.de>

On 01/26/2014 12:44 PM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <1390507020-15766-2-git-send-email-swarren@wwwdotorg.org> you wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> This could be used in scripts such as:
>>
>> if exists mmc 0:1 /boot/boot.scr; then
>>     load mmc 0:1 ${scriptaddr} /boot/boot.scr
>>     source ${scriptaddr}
>> fi
> 
> I understand and agree with your intentions, but I dislike to invent a
> new, totally non-standard command.
> 
> In UNIX, we would use the "test" command for such purposes.  Would it
> not make sense to implement this feature in a more compatible way?  we
> have "test", soo, so we should be able to plug it in there?
> 
> What do you think?

I thought that "test -e mmc 0:1 /boot/boot.scr" was different enough
from a regular Unix shell's single-argument path that it would look a
little weird. Still, it works out fine, so I've sent V3 that implements
this via test instead.

  reply	other threads:[~2014-01-27 20:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 19:56 [U-Boot] [PATCH V2 1/5] fs: fix generic save command implementation Stephen Warren
2014-01-23 19:56 ` [U-Boot] [PATCH V2 2/5] fs: implement infra-structure for an 'exists' function Stephen Warren
2014-01-26 15:41   ` Simon Glass
2014-01-27 17:03     ` Stephen Warren
2014-01-27 17:50       ` Simon Glass
2014-01-26 19:44   ` Wolfgang Denk
2014-01-27 20:51     ` Stephen Warren [this message]
2014-01-27 21:44       ` Wolfgang Denk
2014-01-23 19:56 ` [U-Boot] [PATCH V2 3/5] sandbox: implement fs_exists() and 'sb exists' shell function Stephen Warren
2014-01-26 15:42   ` Simon Glass
2014-01-23 19:56 ` [U-Boot] [PATCH V2 4/5] ext4: implement exists() for ext4fs Stephen Warren
2014-01-26 15:45   ` Simon Glass
2014-01-23 19:57 ` [U-Boot] [PATCH V2 5/5] fat: implement exists() for FAT fs Stephen Warren
2014-01-26 15:52   ` Simon Glass
2014-01-27 17:09     ` Stephen Warren
2014-01-26 15:26 ` [U-Boot] [PATCH V2 1/5] fs: fix generic save command implementation Simon Glass
2014-01-27 17:00   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E6C6CC.7000604@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.