From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] Remove unsupported / empty .bdrv_make_empty functions
Date: Mon, 27 Jan 2014 14:13:39 -0700 [thread overview]
Message-ID: <52E6CC03.1070304@redhat.com> (raw)
In-Reply-To: <cover.1390856648.git.jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 01/27/2014 02:09 PM, Jeff Cody wrote:
> QED and QCOW2 both have .bdrv_make_empty stubs that do nothing. In the
> case of QED, it returns an error (-ENOTSUP), which causes problems with
> bdrv_commit().
>
> This removes those stubs.
>
> Jeff Cody (2):
> block: remove QED .bdrv_make_empty implementation
> block: remove qcow2 .bdrv_make_empty implementation
>
> block/qcow2.c | 21 ---------------------
> block/qed.c | 6 ------
> 2 files changed, 27 deletions(-)
Always fun when you can fix bugs by pure deletion :)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-01-27 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 21:09 [Qemu-devel] [PATCH 0/2] Remove unsupported / empty .bdrv_make_empty functions Jeff Cody
2014-01-27 21:09 ` [Qemu-devel] [PATCH 1/2] block: remove QED .bdrv_make_empty implementation Jeff Cody
2014-01-28 0:35 ` Benoît Canet
2014-01-27 21:09 ` [Qemu-devel] [PATCH 2/2] block: remove qcow2 " Jeff Cody
2014-01-28 0:36 ` Benoît Canet
2014-01-27 21:13 ` Eric Blake [this message]
2014-01-28 9:21 ` [Qemu-devel] [PATCH 0/2] Remove unsupported / empty .bdrv_make_empty functions Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E6CC03.1070304@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.