From: "xinhui.pan" <xinhuix.pan@intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-gpio@vger.kernel.org, david.a.cohen@linux.intel.com,
linus.walleij@linaro.org, gnurou@gmail.com,
yanmin_zhang@linux.intel.com
Subject: [PATCH] gpio-intel-mid: fix the incorrect return of idle callback
Date: Tue, 28 Jan 2014 16:50:57 +0800 [thread overview]
Message-ID: <52E76F71.4080304@intel.com> (raw)
From: "xinhui.pan" <xinhuiX.pan@intel.com>
intel_gpio_runtime_idle should return correct error code if it do fail.
make it more correct even though -EBUSY is the most possible return value.
Signed-off-by: bo.he <bo.he@intel.com>
Signed-off-by: xinhui.pan <xinhuiX.pan@intel.com>
---
drivers/gpio/gpio-intel-mid.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
index d1b50ef..05749a3 100644
--- a/drivers/gpio/gpio-intel-mid.c
+++ b/drivers/gpio/gpio-intel-mid.c
@@ -394,7 +394,9 @@ static const struct irq_domain_ops intel_gpio_irq_ops = {
static int intel_gpio_runtime_idle(struct device *dev)
{
- pm_schedule_suspend(dev, 500);
+ int err = pm_schedule_suspend(dev, 500);
+ if (err)
+ return err;
return -EBUSY;
}
--
1.7.9.5
next reply other threads:[~2014-01-28 8:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 8:50 xinhui.pan [this message]
2014-01-28 16:48 ` [PATCH] gpio-intel-mid: fix the incorrect return of idle callback David Cohen
2014-01-28 16:49 ` Felipe Balbi
2014-01-28 16:49 ` Felipe Balbi
2014-01-28 17:24 ` David Cohen
2014-01-28 18:12 ` Felipe Balbi
2014-01-28 18:12 ` Felipe Balbi
2014-01-29 0:13 ` David Cohen
2014-01-29 7:23 ` xinhui.pan
2014-01-29 7:23 ` xinhui.pan
2014-01-29 19:12 ` David Cohen
2014-01-29 19:12 ` David Cohen
2014-01-29 19:52 ` Felipe Balbi
2014-01-29 19:52 ` Felipe Balbi
2014-01-29 21:06 ` David Cohen
2014-01-29 21:06 ` David Cohen
-- strict thread matches above, loose matches on Subject: below --
2014-01-30 12:15 xinhui.pan
2014-01-30 12:15 ` xinhui.pan
2014-01-31 20:50 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E76F71.4080304@intel.com \
--to=xinhuix.pan@intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.