Re: [PATCH] btrfs-progs: update INSTALL file

[Anand Jain <Anand.Jain@oracle.com>]

  Yep. I had the same opinion as well but was hesitant
  to make wide changes unless understand the backaground.
  Now would try to re-write as a whole and review will help.

Thanks, Anand

On 01/28/2014 02:27 AM, David Sterba wrote:
> On Wed, Jan 22, 2014 at 02:19:37PM +0800, Anand Jain wrote:
>> --- a/INSTALL
>> +++ b/INSTALL
>> @@ -12,7 +12,8 @@ complete:
>>   modprobe libcrc32c
>>   insmod btrfs.ko
>>
>> -The Btrfs utility programs require libuuid to build.  This can be found
>> +The Btrfs utility programs (btrfs-progs) require libattr zlib libacl
>> +e2fsprogs libblkid lzo2 to build.  This can be found
>
> The following sentence does not make sense in the context of the
> extended list, also I think that the dependencies should be listed one
> per-line so it's more clear.
>
>>   in the e2fsprogs sources, and is usually available as libuuid or
>>   e2fsprogs-devel from various distros.
>
> The whole file looks very obsolete, mentions kernel module dependencies
> as well. Not a priority, but I wouldn't mind trimming the unrelated
> information and keep just what's related to userspace, eg. how to build,
> run local tests, where to find git sources.
>