All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Otubo <otubo@linux.vnet.ibm.com>
To: Felix Geyer <debfx@fobos.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] seccomp: add timerfd_create and timerfd_settime to the whitelist
Date: Tue, 28 Jan 2014 11:00:56 -0200	[thread overview]
Message-ID: <52E7AA08.5040909@linux.vnet.ibm.com> (raw)
In-Reply-To: <52E4FDC4.3050204@fobos.de>



On 01/26/2014 10:21 AM, Felix Geyer wrote:
> libusb calls timerfd_create() and timerfd_settime() when it's built with
> timerfd support.
>
> Command to reproduce:
>
> qemu -sandbox on -monitor stdio -device piix3-usb-uhci,id=usb
>       -device usb-host,hostbus=1,hostaddr=3,id=hostdev0
>
> Log messages:
>
> audit(1390730418.924:135): auid=4294967295 uid=121 gid=103 ses=4294967295
>                             pid=5232 comm="qemu-system-x86" sig=31 syscall=283
>                             compat=0 ip=0x7f2b0f4e96a7 code=0x0
> audit(1390733100.580:142): auid=4294967295 uid=121 gid=103 ses=4294967295
>                             pid=16909 comm="qemu-system-x86" sig=31 syscall=286
>                             compat=0 ip=0x7f03513a06da code=0x0
>
> Signed-off-by: Felix Geyer <debfx@fobos.de>
> ---
>   qemu-seccomp.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index caa926e..2705468 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -225,7 +225,9 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
>       { SCMP_SYS(fchmod), 240 },
>       { SCMP_SYS(shmget), 240 },
>       { SCMP_SYS(shmat), 240 },
> -    { SCMP_SYS(shmdt), 240 }
> +    { SCMP_SYS(shmdt), 240 },
> +    { SCMP_SYS(timerfd_create), 240 },
> +    { SCMP_SYS(timerfd_settime), 240 }

Did you deliberately set the priority to 240? Or did you run any sort of 
benchmark (strace) to find this value?

Regards,

-- 
Eduardo Otubo
IBM Linux Technology Center

  reply	other threads:[~2014-01-28 13:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-26 12:21 [Qemu-devel] [PATCH] seccomp: add timerfd_create and timerfd_settime to the whitelist Felix Geyer
2014-01-28 13:00 ` Eduardo Otubo [this message]
2014-01-28 18:03   ` Felix Geyer
2014-01-28 19:27     ` Eduardo Otubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E7AA08.5040909@linux.vnet.ibm.com \
    --to=otubo@linux.vnet.ibm.com \
    --cc=debfx@fobos.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.