From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8BbN-0007bq-WB for qemu-devel@nongnu.org; Tue, 28 Jan 2014 11:33:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8BbG-0003Rm-02 for qemu-devel@nongnu.org; Tue, 28 Jan 2014 11:33:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8BbF-0003Rh-OL for qemu-devel@nongnu.org; Tue, 28 Jan 2014 11:33:21 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0SGXJf2018713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 Jan 2014 11:33:20 -0500 Message-ID: <52E7DBCC.3070301@redhat.com> Date: Tue, 28 Jan 2014 17:33:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1390922439-30750-1-git-send-email-dgilbert@redhat.com> <52E7CFAB.6090801@redhat.com> <20140128163154.GB31213@work-vm> In-Reply-To: <20140128163154.GB31213@work-vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] Name threads List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: lersek@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Il 28/01/2014 17:31, Dr. David Alan Gilbert ha scritto: >> > I plead guilty to bikeshedding and propose s/namethreads/threads/. > If I need to reroll anyway I'll change that; although I just suggested > making it debug-thread in my reply to Michael to make it clear it wasn't > an API. Even better. >> > Also, how did you test the merging of options? Perhaps parse_name >> > could itself call qemu_find_opts("name"), and could be called just >> > once at the end of option parsing. But that's just how *I* would >> > have written the code, and what you have is fine if it works with >> > multiple occurrences of -name. > I was trying to follow the closest example I could find; but > the multiple --name seems to woke out ok; with a bit of debug > if I do: > > ./bin/qemu-system-x86_64 --name foo,namethreads=off --name process=bar --name namethreads=on > parse_name: setting namethreads=0 > parse_name: qemu_name=foo proc_name=(null) > parse_name: setting namethreads=0 > parse_name: qemu_name=foo proc_name=bar > parse_name: setting namethreads=1 > parse_name: qemu_name=foo proc_name=bar > > So I think that ends up with the right result; it doesn't stop you from repeating > options, but I think takes the last one. Good, thanks! Paolo