Re: [meta-fsl-arm-extra][PATCH 2/3] Add U-Boot Recipe for MarS Board by Embest-Tech Using Git Repository git://github.com/embest-tech/uboot-imx.git

[Daiane Angolini <daiane.angolini@freescale.com>]

On 28-01-2014 21:20, Sven Ebenfeld wrote:
>
> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
> ---
>   recipes-bsp/u-boot/u-boot-mars_2009.08.bb |   40 +++++++++++++++++++++++++++++
>   1 file changed, 40 insertions(+)
>   create mode 100644 recipes-bsp/u-boot/u-boot-mars_2009.08.bb
>
> diff --git a/recipes-bsp/u-boot/u-boot-mars_2009.08.bb b/recipes-bsp/u-boot/u-boot-mars_2009.08.bb
> new file mode 100644
> index 0000000..72e4655
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-mars_2009.08.bb
> @@ -0,0 +1,40 @@
> +# Copyright (C) 2011 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Bootloader for MarS-Board from embest-tech"
> +require recipes-bsp/u-boot/u-boot.inc
> +
> +PROVIDES += "u-boot"
> +
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=4c6cde5df68eff615d36789dc18edd3b"
> +
> +DEPENDS_mxs += "elftosb-native"

I don't understand this DEPENDS_mxs

> +
> +PR = "r0"
Please, drop PR

> +SRCREV = "fd0898ed076415a2378b8ba85da8c11a0bc07126"
> +
> +SRC_URI = "git://github.com/embest-tech/uboot-imx.git"
> +
> +UBOOT_MACHINE_marsboard = "mx6q_marsboard_config"
> +
> +UBOOT_MAKE_TARGET = "u-boot.bin"
> +
> +# Please, add the following variables to conf/local.conf
> +# in order to use this u-boot version
> +# UBOOT_SUFFIX = "bin"
> +# UBOOT_PADDING = "2"
> +# PREFERRED_PROVIDER_u-boot = "u-boot-mars"

I don't like this. You must configure this uboot to be the default one 
for your board.

By the way, are you sure you really need 2009.08 u-boot? Would be better 
to create a .bbppend instead of recreate the recipe here?

> +
> +S = "${WORKDIR}/git"
> +EXTRA_OEMAKE += 'HOSTSTRIP=true'
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +do_compile_prepend() {
> +	if [ "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', 'ld-is-gold', '', d)}" = "ld-is-gold" ] ; then
> +		sed -i 's/$(CROSS_COMPILE)ld/$(CROSS_COMPILE)ld.bfd/g' config.mk
> +	fi
> +}
> +
> +COMPATIBLE_MACHINE = "(marsboard)"
>


-- 
Daiane