From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, george.dunlap@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/4] Revert "xen: arm: force guest memory accesses to cacheable when MMU is disabled"
Date: Wed, 29 Jan 2014 13:22:43 +0000 [thread overview]
Message-ID: <52E900A3.6070307@linaro.org> (raw)
In-Reply-To: <1390997486-3986-1-git-send-email-ian.campbell@citrix.com>
On 29/01/14 12:11, Ian Campbell wrote:
> This reverts commit 89eb02c2204a0b42a0aa169f107bc346a3fef802.
>
> This approach has a short coming in that it breaks when a guest enables its
> MMU (SCTLR.M, disabling HCR.DC) without enabling caches (SCTLR.C) first/at the
> same time. It turns out that FreeBSD does this.
By reverting this patch, you also revert some insteresting fix:
- Fixing HSR_SYSREG_CRN_MASK
- Use of HSR_SYSREG_
I think this both changes should be kept.
Otherwise, I would move this patch at the end of the series if we need
to bisect the code.
--
Julien Grall
next prev parent reply other threads:[~2014-01-29 13:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 12:10 [PATCH 0/4] xen/arm: fix guest builder cache cohenrency (again, again) Ian Campbell
2014-01-29 12:11 ` [PATCH 1/4] Revert "xen: arm: force guest memory accesses to cacheable when MMU is disabled" Ian Campbell
2014-01-29 13:22 ` Julien Grall [this message]
2014-01-29 14:18 ` Ian Campbell
2014-01-29 12:11 ` [PATCH 2/4] xen: arm: rename create_p2m_entries to apply_p2m_changes Ian Campbell
2014-01-29 13:18 ` Julien Grall
2014-01-29 12:11 ` [PATCH 3/4] xen: arm: rename p2m next_gfn_to_relinquish to lowest_mapped_gfn Ian Campbell
2014-01-29 13:19 ` Julien Grall
2014-01-29 12:11 ` [PATCH 4/4] xen/arm: clean and invalidate all guest caches by VMID after domain build Ian Campbell
2014-01-29 13:00 ` Jan Beulich
2014-01-29 13:28 ` Stefano Stabellini
2014-01-29 14:15 ` Ian Campbell
2014-01-29 15:01 ` Jan Beulich
2014-01-29 16:35 ` Ian Campbell
2014-01-29 16:50 ` Jan Beulich
2014-01-30 11:26 ` Ian Jackson
2014-01-30 12:24 ` Ian Campbell
2014-01-30 12:32 ` Ian Campbell
2014-01-29 13:26 ` [PATCH 0/4] xen/arm: fix guest builder cache cohenrency (again, again) Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E900A3.6070307@linaro.org \
--to=julien.grall@linaro.org \
--cc=george.dunlap@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.