From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/4] Revert "xen: arm: force guest memory accesses to cacheable when MMU is disabled" Date: Wed, 29 Jan 2014 13:22:43 +0000 Message-ID: <52E900A3.6070307@linaro.org> References: <1390997452.31814.90.camel@kazak.uk.xensource.com> <1390997486-3986-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1390997486-3986-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, george.dunlap@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 29/01/14 12:11, Ian Campbell wrote: > This reverts commit 89eb02c2204a0b42a0aa169f107bc346a3fef802. > > This approach has a short coming in that it breaks when a guest enables its > MMU (SCTLR.M, disabling HCR.DC) without enabling caches (SCTLR.C) first/at the > same time. It turns out that FreeBSD does this. By reverting this patch, you also revert some insteresting fix: - Fixing HSR_SYSREG_CRN_MASK - Use of HSR_SYSREG_ I think this both changes should be kept. Otherwise, I would move this patch at the end of the series if we need to bisect the code. -- Julien Grall