From: Antonio Quartulli <antonio@meshcoding.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: properly check pskb_may_pull return value
Date: Thu, 30 Jan 2014 00:15:10 +0100 [thread overview]
Message-ID: <52E98B7E.4000400@meshcoding.com> (raw)
In-Reply-To: <1391037144-2448-1-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
On 30/01/14 00:12, Antonio Quartulli wrote:
> pskb_may_pull() returns 1 on success and 0 in case of failure,
> therefore checking for the return value being negative does
> not make sense at all.
>
I should have added:
This way if the function fails we will probably read beyond the current
skb data buffer.
> Fix this by doing the proper check.
>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-29 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 23:12 [B.A.T.M.A.N.] [PATCH maint] batman-adv: properly check pskb_may_pull return value Antonio Quartulli
2014-01-29 23:15 ` Antonio Quartulli [this message]
2014-02-02 14:38 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E98B7E.4000400@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.