From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= Subject: Re: [PATCH v2 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver Date: Wed, 29 Jan 2014 22:20:48 -0300 Message-ID: <52E9A8F0.8030901@elopez.com.ar> References: <1390993850-9054-1-git-send-email-maxime.ripard@free-electrons.com> <1390993850-9054-4-git-send-email-maxime.ripard@free-electrons.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Mark Brown , Mike Turquette , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kevin.z.m.zh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sunny-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org, shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org, zhuzhenhua-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org To: Maxime Ripard Return-path: In-Reply-To: <1390993850-9054-4-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , List-Id: linux-spi.vger.kernel.org Hi Maxime, El 29/01/14 08:10, Maxime Ripard escribi=F3: > The Allwinner A31 has a new SPI controller IP compared to the older Allwi= nner > SoCs. > > It supports DMA, but the driver only does PIO for now, and DMA will be > supported eventually. > > Signed-off-by: Maxime Ripard > --- (snip) > + struct sun6i_spi *sspi =3D spi_master_get_devdata(master); > + int ret; > + > + ret =3D clk_prepare_enable(sspi->hclk); > + if (ret) { > + dev_err(dev, "Couldn't enable clock 'ahb spi'\n"); > + goto out; > + } > + > + ret =3D clk_prepare_enable(sspi->mclk); > + if (ret) { > + dev_err(dev, "Couldn't enable clock 'ahb spi'\n"); A different message would be nice :) Cheers, Emilio --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/groups/opt_out. From mboxrd@z Thu Jan 1 00:00:00 1970 From: emilio@elopez.com.ar (=?ISO-8859-1?Q?Emilio_L=F3pez?=) Date: Wed, 29 Jan 2014 22:20:48 -0300 Subject: [linux-sunxi] [PATCH v2 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver In-Reply-To: <1390993850-9054-4-git-send-email-maxime.ripard@free-electrons.com> References: <1390993850-9054-1-git-send-email-maxime.ripard@free-electrons.com> <1390993850-9054-4-git-send-email-maxime.ripard@free-electrons.com> Message-ID: <52E9A8F0.8030901@elopez.com.ar> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Maxime, El 29/01/14 08:10, Maxime Ripard escribi?: > The Allwinner A31 has a new SPI controller IP compared to the older Allwinner > SoCs. > > It supports DMA, but the driver only does PIO for now, and DMA will be > supported eventually. > > Signed-off-by: Maxime Ripard > --- (snip) > + struct sun6i_spi *sspi = spi_master_get_devdata(master); > + int ret; > + > + ret = clk_prepare_enable(sspi->hclk); > + if (ret) { > + dev_err(dev, "Couldn't enable clock 'ahb spi'\n"); > + goto out; > + } > + > + ret = clk_prepare_enable(sspi->mclk); > + if (ret) { > + dev_err(dev, "Couldn't enable clock 'ahb spi'\n"); A different message would be nice :) Cheers, Emilio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbaA3BVj (ORCPT ); Wed, 29 Jan 2014 20:21:39 -0500 Received: from yotta.elopez.com.ar ([31.220.24.173]:59807 "EHLO yotta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbaA3BVi (ORCPT ); Wed, 29 Jan 2014 20:21:38 -0500 Message-ID: <52E9A8F0.8030901@elopez.com.ar> Date: Wed, 29 Jan 2014 22:20:48 -0300 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Maxime Ripard CC: linux-sunxi@googlegroups.com, Mark Brown , Mike Turquette , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kevin.z.m.zh@gmail.com, sunny@allwinnertech.com, shuge@allwinnertech.com, zhuzhenhua@allwinnertech.com Subject: Re: [linux-sunxi] [PATCH v2 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver References: <1390993850-9054-1-git-send-email-maxime.ripard@free-electrons.com> <1390993850-9054-4-git-send-email-maxime.ripard@free-electrons.com> In-Reply-To: <1390993850-9054-4-git-send-email-maxime.ripard@free-electrons.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, El 29/01/14 08:10, Maxime Ripard escribió: > The Allwinner A31 has a new SPI controller IP compared to the older Allwinner > SoCs. > > It supports DMA, but the driver only does PIO for now, and DMA will be > supported eventually. > > Signed-off-by: Maxime Ripard > --- (snip) > + struct sun6i_spi *sspi = spi_master_get_devdata(master); > + int ret; > + > + ret = clk_prepare_enable(sspi->hclk); > + if (ret) { > + dev_err(dev, "Couldn't enable clock 'ahb spi'\n"); > + goto out; > + } > + > + ret = clk_prepare_enable(sspi->mclk); > + if (ret) { > + dev_err(dev, "Couldn't enable clock 'ahb spi'\n"); A different message would be nice :) Cheers, Emilio