From: Anders Kaseorg <andersk@MIT.EDU>
To: Jonathan Nieder <jrnieder@gmail.com>,
Olaf Meeuwissen <olaf.meeuwissen@avasys.jp>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pager: set LV=-c alongside LESS=FRSX
Date: Thu, 30 Jan 2014 02:15:47 -0500 [thread overview]
Message-ID: <52E9FC23.2030200@mit.edu> (raw)
In-Reply-To: <20140107021404.GK3881@google.com>
On 01/06/2014 09:14 PM, Jonathan Nieder wrote:
> +test_expect_success TTY 'LESS and LV envvars are set for pagination' '
> + (
> + sane_unset LESS LV &&
> + PAGER="env >pager-env.out" &&
> + export PAGER &&
> +
> + test_terminal git log
> + ) &&
> + grep ^LESS= pager-env.out &&
> + grep ^LV= pager-env.out
> +'
> +
On the Ubuntu PPA builders, I’m seeing this new test fail with SIGPIPE
about half the time:
died of signal 13 at /build/buildd/git-1.9~rc1/t/test-terminal.perl line 33.
not ok 6 - LESS and LV envvars are set for pagination
Although the test seems to work locally for me, I can reproduce a
similar failure just by running
$ GIT_PAGER='env >pager-env.out' ./test-terminal.perl git log
died of signal 13 at ./test-terminal.perl line 33.
Anders
next prev parent reply other threads:[~2014-01-30 7:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <874n6zbqlh.fsf@helix.nebula.avasys.jp>
[not found] ` <20140106193339.GH3881@google.com>
[not found] ` <874n5ghenr.fsf@helix.nebula.avasys.jp>
2014-01-07 2:14 ` [PATCH] pager: set LV=-c alongside LESS=FRSX Jonathan Nieder
2014-01-07 4:09 ` Olaf Meeuwissen
2014-01-07 17:00 ` Junio C Hamano
2014-01-07 18:17 ` Andreas Schwab
2014-01-30 7:15 ` Anders Kaseorg [this message]
2014-01-30 16:42 ` [PATCH jn/pager-lv-default-env] pager test: make fake pager consume all its input Jonathan Nieder
2014-01-31 17:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E9FC23.2030200@mit.edu \
--to=andersk@mit.edu \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=olaf.meeuwissen@avasys.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.