From: Waiman Long <waiman.long@hp.com>
To: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
George Spelvin <linux@horizon.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Daniel J Blueman <daniel@numascale.com>,
Alexander Fyodorov <halcy@yandex.ru>,
Aswin Chandramouleeswaran <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>,
Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@hp.com>
Subject: Re: [PATCH v3 0/2] qspinlock: Introducing a 4-byte queue spinlock
Date: Thu, 30 Jan 2014 10:38:32 -0500 [thread overview]
Message-ID: <52EA71F8.7070308@hp.com> (raw)
In-Reply-To: <52EA139C.8040106@linux.vnet.ibm.com>
On 01/30/2014 03:55 AM, Raghavendra K T wrote:
> On 01/28/2014 11:49 PM, Waiman Long wrote:
>> v2->v3:
>> - Simplify the code by using numerous mode only without an unfair
>> option.
>> - Use the latest smp_load_acquire()/smp_store_release() barriers.
>> - Move the queue spinlock code to kernel/locking.
>> - Make the use of queue spinlock the default for x86-64 without user
>> configuration.
>> - Additional performance tuning.
>>
>
> Could you please point me to any dependency patches I am missing?
> I am getting the compilation error (latest linus tree with
> 9b0cd304f26b9fca140de15deeac2bf357d1f388)
>
> Got something like below
>
> make[1]: Nothing to be done for `all'.
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> make[1]: Nothing to be done for `relocs'.
> CC kernel/bounds.s
> In file included from include/asm-generic/getorder.h:7:0,
> from /test/master/arch/x86/include/asm/page.h:71,
> from /test/master/arch/x86/include/asm/processor.h:17,
> from /test/master/arch/x86/include/asm/atomic.h:6,
> from include/linux/atomic.h:4,
> from include/asm-generic/qspinlock.h:22,
> from
> /test/master/arch/x86/include/asm/spinlock_types.h:15,
> from
> /test/master/arch/x86/include/asm/paravirt_types.h:331,
> from /test/master/arch/x86/include/asm/ptrace.h:65,
> from /test/master/arch/x86/include/asm/alternative.h:8,
> from /test/master/arch/x86/include/asm/bitops.h:16,
> from include/linux/bitops.h:33,
> from include/linux/kernel.h:10,
> from include/asm-generic/bug.h:13,
> from /test/master/arch/x86/include/asm/bug.h:38,
> from include/linux/bug.h:4,
> from include/linux/page-flags.h:9,
> from kernel/bounds.c:9:
> include/linux/log2.h: In function ‘__ilog2_u32’:
> include/linux/log2.h:34:2: error: implicit declaration of function
> ‘fls’ [-Werror=implicit-function-declaration]
> include/linux/log2.h: In function ‘__ilog2_u64’:
> include/linux/log2.h:42:2: error: implicit declaration of function
> ‘fls64’ [-Werror=implicit-function-declaration]
> include/linux/log2.h: In function ‘__roundup_pow_of_two’:
> .
> .
> [trimmed]
>
The code will need to be compiled in either the latest linux tree as the
patches have dependency on some new memory barrier that are in 3.14.
Alternatively, you can compile with the latest tip tree.
If you have already done that, please send me your config file so that I
can reproduce the compilation error in my build environment.
Thanks,
Longman
next prev parent reply other threads:[~2014-01-30 15:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 18:19 [PATCH v3 0/2] qspinlock: Introducing a 4-byte queue spinlock Waiman Long
2014-01-28 18:19 ` [PATCH v3 1/2] qspinlock: Introducing a 4-byte queue spinlock implementation Waiman Long
2014-01-29 0:20 ` Andi Kleen
2014-01-29 0:20 ` Andi Kleen
2014-01-29 2:57 ` George Spelvin
2014-01-29 2:57 ` George Spelvin
2014-01-29 17:57 ` Waiman Long
2014-01-30 17:43 ` Rik van Riel
2014-01-30 19:00 ` Tim Chen
2014-01-30 19:28 ` Peter Zijlstra
2014-01-30 22:27 ` Tim Chen
2014-01-31 18:26 ` Waiman Long
2014-01-31 19:14 ` George Spelvin
2014-01-31 19:28 ` Waiman Long
2014-01-31 19:45 ` Peter Zijlstra
2014-01-31 18:16 ` Waiman Long
2014-01-30 19:35 ` Peter Zijlstra
2014-01-31 18:28 ` Waiman Long
2014-01-31 15:08 ` Peter Zijlstra
2014-01-31 19:24 ` Waiman Long
2014-01-31 19:51 ` Peter Zijlstra
2014-02-03 11:40 ` Peter Zijlstra
2014-02-06 3:10 ` Waiman Long
2014-02-07 18:17 ` Paul E. McKenney
2014-02-03 8:51 ` Raghavendra K T
2014-01-28 18:19 ` [PATCH v3 2/2] qspinlock, x86: Enable x86-64 to use queue spinlock Waiman Long
2014-01-30 17:45 ` Rik van Riel
2014-01-30 8:55 ` [PATCH v3 0/2] qspinlock: Introducing a 4-byte " Raghavendra K T
2014-01-30 15:38 ` Waiman Long [this message]
2014-01-30 18:49 ` Raghavendra K T
2014-02-03 8:51 ` Raghavendra K T
2014-02-06 3:09 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA71F8.7070308@hp.com \
--to=waiman.long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=daniel@numascale.com \
--cc=halcy@yandex.ru \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=thavatchai.makpahibulchoke@hp.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.