All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/6] php: fix for external extensions
Date: Thu, 30 Jan 2014 13:16:05 -0300	[thread overview]
Message-ID: <52EA7AC5.7040905@zacarias.com.ar> (raw)
In-Reply-To: <87ob2ttpro.fsf@dell.be.48ers.dk>

On 01/30/2014 01:09 PM, Peter Korsgaard wrote:
>  > +define PHP_EXTENSIONS_FIXUP
>  > +	$(SED) "/prefix/ s:/usr:$(STAGING_DIR)/usr:" \
>  > +		$(STAGING_DIR)/usr/bin/phpize
> 
> Can't we just add phpize to PHP_CONFIG_SCRIPTS?

See below...

>  > +	$(SED) "/extension_dir/ s:/usr:$(TARGET_DIR)/usr:" \
>  > +		$(STAGING_DIR)/usr/bin/php-config
> 
> Shouldn't this be s/TARGET_DIR/STAGING_DIR/?

No, that's where the extensions will be installed (no DESTDIR or similar
override in the Makefile), so just with this at least we can't do
PHP_CONFIG_SCRIPTS.
Regards.

  reply	other threads:[~2014-01-30 16:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 21:26 [Buildroot] [PATCH 1/6] php: security bump to version 5.5.8 Gustavo Zacarias
2014-01-28 21:26 ` [Buildroot] [PATCH 2/6] php: fix for external extensions Gustavo Zacarias
2014-01-30 16:09   ` Peter Korsgaard
2014-01-30 16:16     ` Gustavo Zacarias [this message]
2014-01-30 16:40       ` Peter Korsgaard
2014-01-30 17:03         ` Gustavo Zacarias
2014-02-12 18:51   ` Peter Korsgaard
2014-01-28 21:26 ` [Buildroot] [PATCH 3/6] php-zmq: new package Gustavo Zacarias
2014-01-28 22:05   ` Thomas Petazzoni
2014-01-28 22:11     ` Gustavo Zacarias
2014-01-28 22:16       ` Thomas Petazzoni
2014-01-28 21:26 ` [Buildroot] [PATCH 4/6] php-yaml: " Gustavo Zacarias
2014-01-28 21:26 ` [Buildroot] [PATCH 5/6] php-ssh2: " Gustavo Zacarias
2014-01-28 21:26 ` [Buildroot] [PATCH 6/6] php-imagick: " Gustavo Zacarias
2014-01-28 21:47 ` [Buildroot] [PATCH 1/6] php: security bump to version 5.5.8 Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EA7AC5.7040905@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.