From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8vC5-0003sY-Av for qemu-devel@nongnu.org; Thu, 30 Jan 2014 12:14:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8vBy-0004nG-JI for qemu-devel@nongnu.org; Thu, 30 Jan 2014 12:14:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51241 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8vBy-0004mz-DA for qemu-devel@nongnu.org; Thu, 30 Jan 2014 12:14:18 -0500 Message-ID: <52EA8866.6050302@suse.de> Date: Thu, 30 Jan 2014 18:14:14 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1391090848-2115-1-git-send-email-armbru@redhat.com> In-Reply-To: <1391090848-2115-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com Am 30.01.2014 15:07, schrieb Markus Armbruster: > error_is_set(&var) is the same as var !=3D NULL, but it takes > whole-program analysis to figure that out. Unnecessarily hard for > optimizers, static checkers, and human readers. Dumb it down to > obvious. >=20 > Gets rid of several dozen Coverity false positives. >=20 > Note that the obvious form is already used in many places. >=20 > Signed-off-by: Markus Armbruster Reviewed-by: Andreas F=E4rber I don't suppose you used a Coccinelle script that we could re-run in the future? ;) Via QMP queue? Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg