From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
blauwirbel@gmail.com, aliguori@amazon.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts as properties to QemuMachineState
Date: Thu, 30 Jan 2014 18:29:43 +0100 [thread overview]
Message-ID: <52EA8C07.5010307@redhat.com> (raw)
In-Reply-To: <1391102898.2197.29.camel@localhost.localdomain>
Il 30/01/2014 18:28, Marcel Apfelbaum ha scritto:
>> > QEMUMachineInitArgs args = { .machine = machine,
>> > .ram_size = ram_size,
>> > .boot_order = boot_order,
>> > .kernel_filename = kernel_filename,
>> > .kernel_cmdline = kernel_cmdline,
>> > .initrd_filename = initrd_filename,
>> > .cpu_model = cpu_model };
>> > machine->init(&args);
> Sure it will be by value or... I plan to replace QEMUMachineInitArgs
> with regular QOM properties of QemuMachineState.
Yes---by value for now, then it can removed when you get to
s/QEMUMachineInitArgs/QemuMachineState.
Including the "old" object by value BTW is how the CPU conversion
started as well.
Paolo
next prev parent reply other threads:[~2014-01-30 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 14:47 [Qemu-devel] [PATCH RFC 0/5] qemu-machine as a QOM object Marcel Apfelbaum
2014-01-30 14:47 ` [Qemu-devel] [PATCH RFC 1/5] hw/core: introduced qemu machine as " Marcel Apfelbaum
2014-01-30 14:47 ` [Qemu-devel] [PATCH RFC 2/5] vl: use qemu machine QOM class instead of global machines list Marcel Apfelbaum
2014-01-30 14:47 ` [Qemu-devel] [PATCH RFC 3/5] hw/boards: converted current_machine to be an instance of QemuMachineCLass Marcel Apfelbaum
2014-01-30 14:47 ` [Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts as properties to QemuMachineState Marcel Apfelbaum
2014-01-30 16:48 ` Paolo Bonzini
2014-01-30 17:28 ` Marcel Apfelbaum
2014-01-30 17:29 ` Paolo Bonzini [this message]
2014-01-30 14:47 ` [Qemu-devel] [PATCH RFC 5/5] vl.c: set current_machine's properties Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA8C07.5010307@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.