All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Orit Wasserman <owasserm@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, anthony@codemonkey.ws, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors
Date: Thu, 30 Jan 2014 11:25:56 -0700	[thread overview]
Message-ID: <52EA9934.3060802@redhat.com> (raw)
In-Reply-To: <1391066055-17024-2-git-send-email-owasserm@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On 01/30/2014 12:14 AM, Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> ---
>  arch_init.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/arch_init.c b/arch_init.c
> index 77912e7..66f5e82 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -617,6 +617,9 @@ static void migration_end(void)
>          g_free(XBZRLE.current_buf);
>          g_free(XBZRLE.decoded_buf);
>          XBZRLE.cache = NULL;
> +        XBZRLE.encoded_buf = NULL;
> +        XBZRLE.current_buf = NULL;
> +        XBZRLE.decoded_buf = NULL;
>      }
>  }
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-01-30 18:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30  7:14 [Qemu-devel] [PATCH 0/6] XBZRLE Fixes Orit Wasserman
2014-01-30  7:14 ` [Qemu-devel] [PATCH 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors Orit Wasserman
2014-01-30 18:25   ` Eric Blake [this message]
2014-01-30  7:14 ` [Qemu-devel] [PATCH 2/6] Add check for cache size smaller than page size Orit Wasserman
2014-01-30  7:14 ` [Qemu-devel] [PATCH 3/6] migration:fix free XBZRLE decoded_buf wrong Orit Wasserman
2014-02-04 15:01   ` Juan Quintela
2014-01-30  7:14 ` [Qemu-devel] [PATCH 4/6] XBZRLE cache size should not be larger than guest memory size Orit Wasserman
2014-02-04 15:01   ` Juan Quintela
2014-01-30  7:14 ` [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache Orit Wasserman
2014-01-30 15:48   ` Dr. David Alan Gilbert
2014-01-30 17:51     ` Orit Wasserman
2014-01-30  7:14 ` [Qemu-devel] [PATCH 6/6] Don't abort on memory allocation error Orit Wasserman
2014-01-30 16:08   ` Dr. David Alan Gilbert
2014-01-30 17:55     ` Orit Wasserman
2014-02-04 15:00   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EA9934.3060802@redhat.com \
    --to=eblake@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=owasserm@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.