From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Gleb Natapov <gleb@kernel.org>
Cc: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
Dominik Dingel <dingel@linux.vnet.ibm.com>
Subject: Re: [PULL 5/8] KVM: async_pf: Provide additional direct page notification
Date: Fri, 31 Jan 2014 14:13:10 +0100 [thread overview]
Message-ID: <52EBA166.5060805@redhat.com> (raw)
In-Reply-To: <52EB960B.2000307@de.ibm.com>
Il 31/01/2014 13:24, Christian Borntraeger ha scritto:
> On 31/01/14 12:38, Paolo Bonzini wrote:
>> Il 30/01/2014 13:53, Christian Borntraeger ha scritto:
>>> +static inline void kvm_async_page_present_async(struct kvm_vcpu *vcpu,
>>> + struct kvm_async_pf *work)
>>> +{
>>> +#ifndef CONFIG_KVM_ASYNC_PF_SYNC
>>> + kvm_arch_async_page_present(vcpu, work);
>>> +#endif
>>> +}
>>> +
>>
>> This is not used, should it be used in kvm_check_async_pf_completion?
>
> Yes. Looks like this got mixed up when updating the branch from before
> commit f2e106692d5189303997ad7b96de8d8123aa5613 (KVM: Drop FOLL_GET in
> GUP when doing async page fault) on top of this commit. Do you want a
> respin of the series or an on top patch?
It should only break s390, so your call. I think a respin would be
preferrable for you. :)
Paolo
next prev parent reply other threads:[~2014-01-31 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 12:53 [PULL 0/8] KVM: s390: floating interrupt controller and asyncpf Christian Borntraeger
2014-01-30 12:53 ` [PULL 1/8] KVM: s390: add and extend interrupt information data structs Christian Borntraeger
2014-01-30 12:53 ` [PULL 2/8] KVM: s390: add floating irq controller Christian Borntraeger
2014-01-30 12:53 ` [PULL 3/8] KVM: s390: limit floating irqs Christian Borntraeger
2014-01-30 12:53 ` [PULL 4/8] KVM: s390: Add FAULT_FLAG_RETRY_NOWAIT for guest fault Christian Borntraeger
2014-01-30 12:53 ` [PULL 5/8] KVM: async_pf: Provide additional direct page notification Christian Borntraeger
2014-01-31 11:38 ` Paolo Bonzini
2014-01-31 12:24 ` Christian Borntraeger
2014-01-31 13:13 ` Paolo Bonzini [this message]
2014-01-31 13:32 ` [PATCH] Fixup for patch 5 Christian Borntraeger
2014-01-31 13:32 ` [PATCH] KVM: async_pf: Add missing call for async page present Christian Borntraeger
2014-01-31 14:58 ` [PATCH] Fixup for patch 5 Paolo Bonzini
2014-01-30 12:53 ` [PULL 6/8] KVM: async_pf: Allow to wait for outstanding work Christian Borntraeger
2014-01-30 12:53 ` [PULL 7/8] KVM: async_pf: Async page fault support on s390 Christian Borntraeger
2014-01-30 12:53 ` [PULL 8/8] KVM: async_pf: Exploit one reg interface for pfault Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EBA166.5060805@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.