From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] board: bcm28155_ap: Add board files
Date: Fri, 31 Jan 2014 09:17:04 -0500 [thread overview]
Message-ID: <52EBB060.5020207@ti.com> (raw)
In-Reply-To: <52EADACA.4040703@broadcom.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/30/2014 06:05 PM, Darwin Rambo wrote:
>
>
> On 14-01-29 02:33 PM, Tom Rini wrote:
>> On Mon, Jan 27, 2014 at 10:53:30AM -0800, Darwin Rambo wrote:
>>
>>> Add support for the bcm28155_ap reference board.
>>>
>>> Signed-off-by: Darwin Rambo <drambo@broadcom.com> Reviewed-by:
>>> Steve Rae <srae@broadcom.com> Reviewed-by: Tim Kryger
>>> <tkryger@linaro.org>
>> [snip]
>>> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
>>
>> Please use get_ram_size(...);
> We tried using this on our reference board and it hangs accessing
> memory regions that are not populated. Our memory controller
> doesn't appear to properly support accessing regions that are not
> backed by physical sdram. So I think it's best to keep this code as
> is and consider this approach for future designs.
Wait, what did you do? get_ram_size(base, max) must work and return
CONFIG_SYS_SDRAM_SIZE, or you haven't properly configured your
controller (as get_ram_size just pokes parts of the specified range).
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJS67BgAAoJENk4IS6UOR1W5/sP/1oi/VC3Vd1Aa9R0Cn833caG
ewiuDEWbuXVfa9+yeHIcr/VcyzEF16AxMqUpguaDukI34sdlUHxVlaJKDqLkMp/t
fxNRQb8lNK6vhHK3F7xdKiMAFbvAm2fLDLii3mLAZjKGBU6/5kexSaKeklRJbmhz
kyLRk3MejoXupNXRhHb48ZK9csgO7JHLNhQCwEIAxzuXhBbnw3Bjt09vBCET0Kfj
no4o5TGH9kBOs2/DeO3zSqK3VqbSOgAH1uGYiaiC2cV9vni7Fdq1lshVI/Is+ete
0XkxxfD2pSAerUnQdyiaCJUWxomwLuPxxD/EcNkNMuEBHnOEnYHaNVA9FIdQGJRD
GNIiR2UgtktHLedVRsUd19VyGEy3RVPW1urjy59hrU68P1WBxi20nEAxzWi+QuYy
KefuYlZfiZ+rHO5P2SOJRPVgrCxcGEfBLztwaeTy2h54asCwctCyx7cwHDJJOkEk
7WtojfwaaaAsL0FGj1XK3hq/MeSjaK1zFOPsnuozZOXLUyEe0iElbqJVO2Ur0UD8
CJugsFM2ywJGsTkk3OvlW7uX1yoMQo5yvV0bNFWhj3XoGX7gpKxiZdFZZkqqc/7U
HgTLP4fvLdXLbfdrHamEIQvWHztidsYNlkHdzts7Yzw1e5DszsO16+J/qW5NKcNI
4sfMcXpzoPqiX0WxpEEJ
=FNlU
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-01-31 14:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 18:53 [U-Boot] [PATCH 0/6] Introducing the Broadcom bcm281xx Architecture Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 1/6] arch: kona: Initial commit of kona-common architecture code Darwin Rambo
2014-01-29 22:32 ` Tom Rini
2014-01-30 23:09 ` Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 2/6] arch: bcm281xx: Initial commit of bcm281xx " Darwin Rambo
2014-01-29 22:32 ` Tom Rini
2014-01-30 22:03 ` Darwin Rambo
2014-01-31 17:54 ` Tom Rini
2014-01-31 18:19 ` Darwin Rambo
2014-01-31 17:47 ` Matt Porter
2014-01-27 18:53 ` [U-Boot] [PATCH 3/6] gpio: kona: Add Kona gpio driver Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 4/6] i2c: kona: Add Kona I2C driver Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 5/6] mmc: kona: Add Kona mmc driver Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 6/6] board: bcm28155_ap: Add board files Darwin Rambo
2014-01-29 22:33 ` Tom Rini
2014-01-30 23:05 ` Darwin Rambo
2014-01-31 14:17 ` Tom Rini [this message]
2014-01-31 17:05 ` Tim Kryger
2014-01-31 17:15 ` Tom Rini
2014-01-31 18:18 ` Darwin Rambo
2014-01-29 22:32 ` [U-Boot] [PATCH 0/6] Introducing the Broadcom bcm281xx Architecture Tom Rini
2014-01-30 23:12 ` Darwin Rambo
2014-01-31 19:14 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EBB060.5020207@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.