From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
libvir-list@redhat.com, "Jiri Denemark" <jdenemar@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7
Date: Fri, 31 Jan 2014 17:52:57 +0100 [thread overview]
Message-ID: <52EBD4E9.2000700@redhat.com> (raw)
In-Reply-To: <20140131164207.GZ2221@otherpad.lan.raisama.net>
Il 31/01/2014 17:42, Eduardo Habkost ha scritto:
>> > It looks like only -device would be able to create actual CPU models,
>> > but for -device to work we need as minimum this series and conversion
>> > of CPU features to properties in tree. Then I guess we can override
>> > cannot_instantiate_with_device_add_yet for x86 CPUs.
> Setting cannot_instantiate_with_device_add_yet=false looks much simpler
> than implementing UserCreatable. My question is: may we do that, already
> (once this series gets included), or is there something else holding us
> from doing it?
Once you make something creatable with "-object", the API must not
change anymore. So we would have to think twice about that.
Allowing -device may be okay, since in the (very?) long term -device can
be replaced by -object. But -object is definitive.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Cc: libvir-list@redhat.com, "Jiri Denemark" <jdenemar@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7
Date: Fri, 31 Jan 2014 17:52:57 +0100 [thread overview]
Message-ID: <52EBD4E9.2000700@redhat.com> (raw)
In-Reply-To: <20140131164207.GZ2221@otherpad.lan.raisama.net>
Il 31/01/2014 17:42, Eduardo Habkost ha scritto:
>> > It looks like only -device would be able to create actual CPU models,
>> > but for -device to work we need as minimum this series and conversion
>> > of CPU features to properties in tree. Then I guess we can override
>> > cannot_instantiate_with_device_add_yet for x86 CPUs.
> Setting cannot_instantiate_with_device_add_yet=false looks much simpler
> than implementing UserCreatable. My question is: may we do that, already
> (once this series gets included), or is there something else holding us
> from doing it?
Once you make something creatable with "-object", the API must not
change anymore. So we would have to think twice about that.
Allowing -device may be okay, since in the (very?) long term -device can
be replaced by -object. But -object is definitive.
Paolo
next prev parent reply other threads:[~2014-01-31 16:53 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 19:48 [uq/master PATCH 0/7] x86 CPU subclasses, take 7 Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-01-30 19:48 ` [uq/master PATCH 1/7] target-i386: Eliminate CONFIG_KVM #ifdefs Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 11:42 ` Paolo Bonzini
2014-01-31 11:42 ` [Qemu-devel] " Paolo Bonzini
2014-01-30 19:48 ` [uq/master PATCH 2/7] target-i386: Don't change x86_def_t struct on cpu_x86_register() Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 11:42 ` Paolo Bonzini
2014-01-31 11:42 ` [Qemu-devel] " Paolo Bonzini
2014-01-30 19:48 ` [uq/master PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 11:42 ` Paolo Bonzini
2014-01-31 11:42 ` [Qemu-devel] " Paolo Bonzini
2014-01-30 19:48 ` [uq/master PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def() Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 11:42 ` Paolo Bonzini
2014-01-31 11:42 ` [Qemu-devel] " Paolo Bonzini
2014-02-10 0:03 ` Andreas Färber
2014-01-30 19:48 ` [uq/master PATCH 5/7] target-i386: Call x86_cpu_load_def() earlier Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-02-10 0:13 ` Andreas Färber
2014-02-10 0:13 ` [Qemu-devel] " Andreas Färber
2014-01-30 19:48 ` [uq/master PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 11:42 ` Paolo Bonzini
2014-01-31 11:42 ` [Qemu-devel] " Paolo Bonzini
2014-02-10 0:14 ` Andreas Färber
2014-01-30 19:48 ` [uq/master PATCH 7/7] target-i386: CPU model subclasses Eduardo Habkost
2014-01-30 19:48 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 17:20 ` Eduardo Habkost
2014-01-31 17:20 ` Eduardo Habkost
2014-01-31 18:13 ` [uq/master PATCH 7/7 v8] " Eduardo Habkost
2014-01-31 18:13 ` [Qemu-devel] " Eduardo Habkost
2014-02-10 0:23 ` Andreas Färber
2014-02-10 0:23 ` Andreas Färber
2014-02-10 8:19 ` Eduardo Habkost
2014-02-10 8:19 ` Eduardo Habkost
2014-02-10 8:26 ` Eduardo Habkost
2014-02-10 8:26 ` Eduardo Habkost
2014-02-10 10:21 ` [qom-cpu PATCH 7/7 v9] " Eduardo Habkost
2014-02-10 10:21 ` [Qemu-devel] " Eduardo Habkost
2014-02-10 22:39 ` Andreas Färber
2014-02-10 22:39 ` [Qemu-devel] " Andreas Färber
2014-02-11 8:05 ` Eduardo Habkost
2014-02-11 8:05 ` [Qemu-devel] " Eduardo Habkost
2014-02-11 8:07 ` Paolo Bonzini
2014-02-11 8:07 ` [Qemu-devel] " Paolo Bonzini
2014-02-10 9:48 ` [Qemu-devel] [uq/master PATCH 7/7 v8] " Igor Mammedov
2014-02-10 9:48 ` Igor Mammedov
2014-01-30 21:47 ` [uq/master PATCH 0/7] x86 CPU subclasses, take 7 Paolo Bonzini
2014-01-30 21:47 ` [Qemu-devel] " Paolo Bonzini
2014-01-31 11:30 ` Andreas Färber
2014-01-31 11:30 ` [Qemu-devel] " Andreas Färber
2014-01-31 11:42 ` Paolo Bonzini
2014-01-31 11:42 ` [Qemu-devel] " Paolo Bonzini
2014-01-31 12:17 ` Eduardo Habkost
2014-01-31 12:17 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 12:14 ` Eduardo Habkost
2014-01-31 12:14 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 14:36 ` Igor Mammedov
2014-01-31 14:36 ` [Qemu-devel] " Igor Mammedov
2014-01-31 14:48 ` Igor Mammedov
2014-01-31 14:48 ` Igor Mammedov
2014-01-31 14:50 ` Paolo Bonzini
2014-01-31 14:50 ` Paolo Bonzini
2014-01-31 15:17 ` Eduardo Habkost
2014-01-31 15:17 ` Eduardo Habkost
2014-01-31 16:06 ` Igor Mammedov
2014-01-31 16:06 ` Igor Mammedov
2014-01-31 16:42 ` Eduardo Habkost
2014-01-31 16:42 ` Eduardo Habkost
2014-01-31 16:52 ` Paolo Bonzini [this message]
2014-01-31 16:52 ` Paolo Bonzini
2014-01-31 18:51 ` Eduardo Habkost
2014-01-31 18:51 ` Eduardo Habkost
2014-01-31 18:56 ` [libvirt] " Eric Blake
2014-01-31 18:56 ` [Qemu-devel] [libvirt] " Eric Blake
2014-01-31 19:08 ` [libvirt] [Qemu-devel] " Eduardo Habkost
2014-01-31 19:08 ` [Qemu-devel] [libvirt] " Eduardo Habkost
2014-01-31 19:18 ` Igor Mammedov
2014-01-31 19:18 ` Igor Mammedov
2014-01-31 19:25 ` Eduardo Habkost
2014-01-31 19:25 ` Eduardo Habkost
2014-01-31 15:10 ` [Qemu-devel] " Eduardo Habkost
2014-01-31 15:10 ` Eduardo Habkost
2014-01-31 15:11 ` Paolo Bonzini
2014-01-31 15:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EBD4E9.2000700@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.