All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/3] hwmon: (lm63) Create attributes for LM96163 in one call
Date: Sun, 02 Feb 2014 18:15:11 +0000	[thread overview]
Message-ID: <52EE8B2F.1030906@roeck-us.net> (raw)
In-Reply-To: <1390243126-19519-2-git-send-email-linux@roeck-us.net>

On 02/02/2014 10:02 AM, Jean Delvare wrote:
> Hi Guenter,
>
> On Mon, 20 Jan 2014 10:38:44 -0800, Guenter Roeck wrote:
>> There is no need to have both an attribute group plus an individual attribute
>> for LM96163. Add the attribute to the group and create all attributes with one
>> call.
>
> The idea of having groups (or single attributes) per extra feature
> rather than per chip was to be able to reuse them when adding support
> for a new chip implementing a subset of the extra features. It wasn't
> an overlook, it was implemented that way on purpose. You can argue that
> the extra complexity may never be needed, but nobody objected back
> then.
>
Or nobody cared ;-).

> Now I do understand that single attributes don't fit well with the way
> you implemented devm_hwmon_device_register_with_groups(). You could
> still create a group for that attribute so that you can register it
> with that function. Then you only have another group to register, no
> big deal.
>
> Would that be OK for you?
>

Sure, I can do that, no problem. As you said, no big deal.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2014-02-02 18:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 18:38 [lm-sensors] [PATCH 1/3] hwmon: (lm63) Create attributes for LM96163 in one call Guenter Roeck
2014-02-02 18:02 ` Jean Delvare
2014-02-02 18:15 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EE8B2F.1030906@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.