From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAEeL-0002XX-D3 for qemu-devel@nongnu.org; Mon, 03 Feb 2014 03:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAEeF-0005q0-Er for qemu-devel@nongnu.org; Mon, 03 Feb 2014 03:13:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAEeF-0005pw-6e for qemu-devel@nongnu.org; Mon, 03 Feb 2014 03:12:55 -0500 Message-ID: <52EF4F7F.3010005@redhat.com> Date: Mon, 03 Feb 2014 09:12:47 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1390246471-25167-1-git-send-email-michael@walle.cc> <1390246471-25167-6-git-send-email-michael@walle.cc> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 05/12] milkymist-vgafb: swap pixel data in source buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Michael Walle Cc: QEMU Developers , Anthony Liguori Il 01/02/2014 18:57, Peter Maydell ha scritto: >> > In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was >> > eliminated. But we are reading from the target buffer a 16-bit value, which >> > is in big-endian format. Therefore, swap the bytes if we are building for a >> > little-endian host. > Paolo, can you remember why you included this change in that commit? > It purports to just be moving the display devices around but it seems to > have included the introduction of this bug, and also a removal of a lduw_raw() > call from (what is now) hw/display/blizzard_template.h which I suspect is > also wrong... > Most likely it was an incorrectly squashed patch. Paolo