From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WAQQG-0005Er-LD for mharc-grub-devel@gnu.org; Mon, 03 Feb 2014 15:47:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAQQ6-0005Ec-Fa for grub-devel@gnu.org; Mon, 03 Feb 2014 15:47:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAQPy-0004b1-2f for grub-devel@gnu.org; Mon, 03 Feb 2014 15:47:06 -0500 Received: from mail-ee0-x235.google.com ([2a00:1450:4013:c00::235]:33793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAQPx-0004ax-Ru for grub-devel@gnu.org; Mon, 03 Feb 2014 15:46:57 -0500 Received: by mail-ee0-f53.google.com with SMTP id t10so3909724eei.40 for ; Mon, 03 Feb 2014 12:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=x+PiEXPAteMscCSJ8G/uM/BaqGNsofDSans1loYzUzU=; b=B9HeJGOJZwEKWJSZkuaxRxMq5l9gaAHdLlOBC42OrQFqLJrwb5swe6cNYbrUxwxv6T 61G/mmv1huE6KfWR8nIbTL+fbdefAtBG5qTgpCzUOvKikj1YJnCcl7cseXfgNda78RmB a1NFwVx6kp51yLTkAHP6l+Pkb482zO+qZoc5mVQhGztb5HuTkVpqmK11ZetMN4P4MdmJ wyL9kRMXUI5/d4oKH7dqtp2C80dfqEJ4WPRzxw9iyyxjmOrHtln/5B3kG0a9TQUXPT5z t50N5q95IyQ8Q0q2CV7WAN5MQmNdwJAmCLMS4hbMk44CVgnhREL6q5EqX12jYRO4dKNU p2Mg== X-Received: by 10.14.102.67 with SMTP id c43mr45356607eeg.23.1391460417005; Mon, 03 Feb 2014 12:46:57 -0800 (PST) Received: from [129.132.211.79] (vpn-global-079-dhcp.ethz.ch. [129.132.211.79]) by mx.google.com with ESMTPSA id d9sm53145000eei.9.2014.02.03.12.46.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Feb 2014 12:46:55 -0800 (PST) Message-ID: <52EFC906.2020602@gmail.com> Date: Mon, 03 Feb 2014 17:51:18 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.2.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: grub2 code References: <52EE9BBF.3090906@gmail.com> <20140203115746.GA18795@riva.ucam.org> In-Reply-To: <20140203115746.GA18795@riva.ucam.org> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2ACh9xP7HQvxW6J7er6JRQk4EtV9wU6lg" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::235 Cc: Ben Guthro X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2014 20:47:15 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2ACh9xP7HQvxW6J7er6JRQk4EtV9wU6lg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03.02.2014 12:57, Colin Watson wrote: > movw $(GRUB_MEMORY_MACHINE_BIOS_DATA_AREA_ADDR + 0x17), %bx > andb $3, (%bx) andb $3, (%bx) is equivalent to C code: *(grub_uint8_t *)bx &=3D 3; andb modifies the value at (%bx). You probably meant to use testb which has same flag semantics but doesn't change operands --2ACh9xP7HQvxW6J7er6JRQk4EtV9wU6lg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlLvyQYACgkQmBXlbbo5nOu6vAD+PFvlUk2ET0NsDNJ2BrgbmXfy 8Zp6KwU67a7uj0UPocgA/jtkMrET+RMe4Y1yGudKsH76/LMbZVTU7ljtmLVFARzW =hSQX -----END PGP SIGNATURE----- --2ACh9xP7HQvxW6J7er6JRQk4EtV9wU6lg--