From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
peter.crosthwaite@xilinx.com, stefanha@redhat.com,
mst@redhat.com, jan.kiszka@siemens.com, marcel.a@redhat.com,
armbru@redhat.com, blauwirbel@gmail.com,
alex.williamson@redhat.com, kraxel@redhat.com,
aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v5 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API
Date: Mon, 03 Feb 2014 12:34:44 -0700 [thread overview]
Message-ID: <52EFEF54.2010800@redhat.com> (raw)
In-Reply-To: <1391443030-8662-7-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On 02/03/2014 08:57 AM, Igor Mammedov wrote:
> Split piix4_device_hotplug() into hotplug/unplug callbacks
> and register them as "hotplug-handler" interface implementation of
> PIIX4_PM device.
>
> Replace pci_bus_hotplug() wiring with setting link on
> PCI BUS "hotplug-handler" property to PIIX4_PM device.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> + error_setg(errp, "Not supported bus. Bus doesn't have propery '"
s/Not supported/Unsupported/
s/propery/property/
> + ACPI_PCIHP_PROP_BSEL "' set.");
Drop the trailing '.' - most of our error messages omit it on purpose
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-03 19:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 15:57 [Qemu-devel] [PATCH v5 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API Igor Mammedov
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 1/9] define hotplug interface Igor Mammedov
2014-02-03 19:28 ` Eric Blake
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link Igor Mammedov
2014-02-03 19:30 ` Eric Blake
2014-02-03 20:38 ` Igor Mammedov
2014-02-03 20:50 ` Eric Blake
2014-02-04 8:43 ` Igor Mammedov
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 3/9] qdev: add "hotpluggable" property to Device Igor Mammedov
2014-02-03 19:31 ` Eric Blake
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 4/9] hw/acpi: move typeinfo to the file end Igor Mammedov
2014-02-03 19:32 ` Eric Blake
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 5/9] qdev:pci: refactor PCIDevice to use generic "hotpluggable" property Igor Mammedov
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API Igor Mammedov
2014-02-03 19:34 ` Eric Blake [this message]
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 7/9] pci/shpc: convert SHPC " Igor Mammedov
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 8/9] pci/pcie: convert PCIE " Igor Mammedov
2014-02-03 15:57 ` [Qemu-devel] [PATCH v5 9/9] hw/pci: switch to a generic hotplug handling for PCIDevice Igor Mammedov
2014-02-03 19:37 ` [Qemu-devel] [PATCH v5 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API Eric Blake
2014-02-03 20:42 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EFEF54.2010800@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.