From: Michael Marley <michael@michaelmarley.com>
To: tj@kernel.org
Cc: linux-ide@vger.kernel.org
Subject: [PATCH] ACHI: Attempt to enable a single MSI if block enable fails
Date: Mon, 03 Feb 2014 15:39:27 -0500 [thread overview]
Message-ID: <52EFFE7F.6050807@michaelmarley.com> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
From: Michael Marley <michael@michaelmarley.com>
Commit 7b92b4f61ec49cb1a5813298f35258bd7ecd3667 ("PCI/MSI: Remove
pci_enable_msi_block_auto()") causes the AHCI driver to immediately
switch to INTx mode if the pci_enable_msi_block() call fails to
allocate the requested number of MSIs. This behavior causes some
systems (for example, the Lenovo ThinkCentre m57p) to begin using
INTx when they worked fine in single MSI mode before. This patch
makes the driver try to enable a single MSI if the
pci_enable_msi_block() call fails instead of switching directly
to INTx.
Signed-off-by: Michael Marley <michael@michaelmarley.com>
- ---
- --- drivers/ata/ahci.c.orig 2014-02-03 20:00:04.834008843 +0000
+++ drivers/ata/ahci.c 2014-02-03 19:34:53.737257483 +0000
@@ -1171,7 +1171,7 @@ static int ahci_init_interrupts(struct p
nvec = rc;
rc = pci_enable_msi_block(pdev, nvec);
if (rc)
- - goto intx;
+ goto single_msi;
return nvec;
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJS7/5/AAoJEANTUn3blhEaLo8P/31AEbD9b61h2zFAcGlqZmN/
OEp69smHl9DbciaL0nQGIY4TRUpjA2XVxT/ZC3Fdz0huqX226g2D2G7/LLk299r3
m/GC89640FBRaVqNTASNKvIANlq0t2vgdOXGsgLXCD3EAigMdCVLiKNvdDYpUdXo
uaUg7WTVM12U+bWCrTB0RVgU7kKqkPSWb59kUPFaInjrTWzZ4jf4SZEzOr1b6mB0
Ihn/BsMf76q9rzGEwTaKPV+BrS/QZY5oz23r8+Pqw+lNVgtnmCQ7UkRJ40MI3roS
lU68syoG/CjI6imO/TQcr54eHMTBRl55Ut4VO/iLYaJKhXGGsuP43oPrJM0LZzpi
jjwzgz4Bij0Hi5Wx7AS0sDNEERi+w4At/+eKQmUkjA6qUblzIKCpMMCmp0CvodXH
8J9TU9CqcnQs2hgGy990nFxdmiLh+Ee5NFBfKxpTGxv4eAjuK6RbxMLfndF6rRXO
MpMoFMK3BdFnQoi6We5er7HKPcbqOpR2hrw8mALhWDxgv+N2pq1J5uG69mc5vwxJ
YV7N0tnCtVTyxGavtMP669YCNH0KvRzXJvzJRE1TuuTvNu+oudMWJinilyhPnYJk
U5DYzLWj4t42qEsGr3QjFBEv90DG/LNc5YavI9XOfepjGFbdlcGQPAe3HnaE86KD
s9JiFcvAixL295414PRN
=f6LE
-----END PGP SIGNATURE-----
next reply other threads:[~2014-02-03 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 20:39 Michael Marley [this message]
2014-02-03 20:46 ` [PATCH] ACHI: Attempt to enable a single MSI if block enable fails Tejun Heo
2014-02-04 6:01 ` Alexander Gordeev
2014-02-04 16:40 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EFFE7F.6050807@michaelmarley.com \
--to=michael@michaelmarley.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.