All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Hahler <genml+git-2014@thequod.de>
To: git@vger.kernel.org
Subject: Bug: relative core.worktree is resolved from symlink and not its target
Date: Tue, 04 Feb 2014 11:20:39 +0100	[thread overview]
Message-ID: <52F0BEF7.5020600@thequod.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

Hi,

when using a submodule "sm", there is a relative worktree in its config:

   .git/modules/sm/config:
   [core]
    worktree = ../../../smworktree

git-new-worktree (from contrib) symlinks this config the new worktree.

From inside the new worktree, git reads the config, but resolves the
relative worktree setting based on the symlink's location.

A fix would be to resolve any relative worktree setting based on the
symlink target's location (the actual config file), and not from the
symlink.

This is with git version 1.8.5.3.

Please consider fixing this.

(I know about various workarounds, e.g. copying and adjusting "config"
or manually setting $GIT_WORK_TREE; more relevant discussion would be
at http://comments.gmane.org/gmane.comp.version-control.git/196019)


Thanks,
Daniel.

-- 
http://daniel.hahler.de/


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 255 bytes --]

             reply	other threads:[~2014-02-04 10:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 10:20 Daniel Hahler [this message]
2014-02-09  9:08 ` Bug: relative core.worktree is resolved from symlink and not its target Duy Nguyen
2014-02-17  9:36   ` Daniel Hahler
2014-02-17 12:30     ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F0BEF7.5020600@thequod.de \
    --to=genml+git-2014@thequod.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.