From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x Date: Tue, 04 Feb 2014 14:36:50 +0100 Message-ID: <52F0ECF2.9070102@metafoo.de> References: <20140204133014.GA22609@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140204133014.GA22609@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Jean-Francois Moine , alsa-devel@alsa-project.org, Russell King - ARM Linux , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Clark , Dave Airlie , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 02/04/2014 02:30 PM, Mark Brown wrote: [...] > > What does this actually do? No information is being passed in to the > core function here, not even any information on if it's starting or > stopping. Looking at the rest of the code I can't help thinking it > might be clearer to inline this possibly with a lookup helper, the code > is very small and the lack of parameters makes it hard to follow. > >> +static const struct snd_soc_dapm_route tda_routes[] = { >> + { "hdmi-out", NULL, "HDMI I2S Playback" }, >> + { "hdmi-out", NULL, "HDMI SPDIF Playback" }, >> +}; > > S/PDIF. Won't this cause issues with the debugfs widget entries? It's fixable by escaping it (replace it by a dash or something) in the debugfs widget filename, but I don't think we do this right now. - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Tue, 04 Feb 2014 14:36:50 +0100 Subject: [alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x In-Reply-To: <20140204133014.GA22609@sirena.org.uk> References: <20140204133014.GA22609@sirena.org.uk> Message-ID: <52F0ECF2.9070102@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/04/2014 02:30 PM, Mark Brown wrote: [...] > > What does this actually do? No information is being passed in to the > core function here, not even any information on if it's starting or > stopping. Looking at the rest of the code I can't help thinking it > might be clearer to inline this possibly with a lookup helper, the code > is very small and the lack of parameters makes it hard to follow. > >> +static const struct snd_soc_dapm_route tda_routes[] = { >> + { "hdmi-out", NULL, "HDMI I2S Playback" }, >> + { "hdmi-out", NULL, "HDMI SPDIF Playback" }, >> +}; > > S/PDIF. Won't this cause issues with the debugfs widget entries? It's fixable by escaping it (replace it by a dash or something) in the debugfs widget filename, but I don't think we do this right now. - Lars