All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4 of 4 v2] infra: remove unused helper function pkgparentdir
Date: Tue, 04 Feb 2014 18:55:43 +0100	[thread overview]
Message-ID: <52F1299F.7070406@mind.be> (raw)
In-Reply-To: <1ed04f399fb1b71847c1.1391530916@argentina>

On 04/02/14 17:21, Thomas De Schampheleire wrote:
> Thanks to the previous patches, no-one is using pkgparentdir anymore, so
> remove it.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> ---
>  package/pkg-utils.mk |  1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -60,7 +60,6 @@ endef
>  # package, for which the package directory is an empty string.
>  pkgdir       = $(dir $(lastword $(MAKEFILE_LIST)))
>  pkgname      = $(lastword $(subst /, ,$(call pkgdir)))
> -pkgparentdir = $(patsubst %$(call pkgname)/,%,$(call pkgdir))

 The comment above mentions pkgdir but that should actually have been
pkgparentdir (it's the reason that pkgparentdir uses patsubst instead of
the usual $(dir ...)). Basically, the last sentence of the comment can be
removed.

 Regards,
 Arnout


>  
>  # Define extractors for different archive suffixes
>  INFLATE.bz2  = $(BZCAT)
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      reply	other threads:[~2014-02-04 17:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 16:21 [Buildroot] [PATCH 0 of 4 v2] infra: remove FOO_DIR_PREFIX, 4th param of pkg infras, pkgparentdir Thomas De Schampheleire
2014-02-04 16:21 ` [Buildroot] [PATCH 1 of 4 v2] infra: remove variable FOO_DIR_PREFIX Thomas De Schampheleire
2014-02-04 17:55   ` Arnout Vandecappelle
2014-02-04 20:02   ` Yann E. MORIN
2014-02-04 16:21 ` [Buildroot] [PATCH 2 of 4 v2] infra: remove usage of 4th parameter to inner-generic-package Thomas De Schampheleire
2014-02-04 17:46   ` Arnout Vandecappelle
2014-02-04 16:21 ` [Buildroot] [PATCH 3 of 4 v2] infra: remove unused 4th parameter to package infrastructures (pkgparentdir) Thomas De Schampheleire
2014-02-04 16:21 ` [Buildroot] [PATCH 4 of 4 v2] infra: remove unused helper function pkgparentdir Thomas De Schampheleire
2014-02-04 17:55   ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F1299F.7070406@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.