All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@lists.codethink.co.uk,
	Valentine Barshak <valentine.barshak@cogentembedded.com>,
	Simon Horman <horms@verge.net.au>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 2/3] PCI: rcar: add error interrupt handling
Date: Wed, 05 Feb 2014 09:31:45 +0000	[thread overview]
Message-ID: <52F20501.6030909@codethink.co.uk> (raw)
In-Reply-To: <CANqRtoRy9bEUMCDqMtbfa3NvLuuLxda5RN=CZs9V37caNnwdWw@mail.gmail.com>

On 05/02/14 08:50, Magnus Damm wrote:
> On Tue, Jan 28, 2014 at 6:47 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> Add option to enable interrupts to report any errors from
>> the AHB-PCI bridge to help find any issues with the bridge
>> when in use.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

>
> Thanks for your patches. Handling errors sounds good. About this
> particular one, I'm not so keen on introducing Kconfig options for
> each driver. Instead I'd prefer to handle this during runtime or as
> Valentine suggested using CONFIG_PCI_DEBUG.

Ok, I will change to using that.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

  reply	other threads:[~2014-02-05  9:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1390902468-7753-1-git-send-email-ben.dooks@codethink.co.uk>
2014-01-28  9:47 ` [PATCH 1/3] PCI: rcar: check platform_get_irq() return code Ben Dooks
2014-01-28 15:11   ` Sergei Shtylyov
2014-01-28 16:11     ` Sergei Shtylyov
2014-01-28 15:34     ` Ben Dooks
2014-01-28  9:47 ` [PATCH 2/3] PCI: rcar: add error interrupt handling Ben Dooks
2014-02-05  8:50   ` Magnus Damm
2014-02-05  8:50     ` Magnus Damm
2014-02-05  9:31     ` Ben Dooks [this message]
2014-02-05  9:40   ` Andrew Murray
2014-02-05  9:40     ` Andrew Murray
2014-01-28  9:47 ` [PATCH 3/3] PCI: rcar: fix bridge logic abort Ben Dooks
2014-01-28  9:47   ` Ben Dooks
2014-01-28  9:50   ` Ben Dooks
2014-01-28 10:06 PCI fixes for Renesas RCar Ben Dooks
2014-01-28 10:06 ` [PATCH 2/3] PCI: rcar: add error interrupt handling Ben Dooks
2014-01-28 20:47   ` Valentine
2014-01-28 20:47     ` Valentine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F20501.6030909@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=bhelgaas@google.com \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=valentine.barshak@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.