From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 4.mo3.mail-out.ovh.net ([178.33.46.10] helo=mo3.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WB2w2-0003Rg-Ac for linux-mtd@lists.infradead.org; Wed, 05 Feb 2014 13:54:40 +0000 Received: from mail628.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo3.mail-out.ovh.net (Postfix) with SMTP id 06FBAFFB3EE for ; Wed, 5 Feb 2014 14:54:13 +0100 (CET) Message-ID: <52F24255.9030603@overkiz.com> Date: Wed, 05 Feb 2014 14:53:25 +0100 From: Boris BREZILLON MIME-Version: 1.0 To: Brian Norris Subject: Re: [RFC PATCH 1/9] mtd: nand: retrieve ECC requirements from Hynix READ ID byte 4 References: <1389190924-26226-1-git-send-email-b.brezillon@overkiz.com> <1389190924-26226-2-git-send-email-b.brezillon@overkiz.com> <20140123014906.GY8919@ld-irv-0074> In-Reply-To: <20140123014906.GY8919@ld-irv-0074> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, Russell King , linux-doc@vger.kernel.org, dev@linux-sunxi.org, linux-kernel@vger.kernel.org, Huang Shijie , linux-mtd@lists.infradead.org, Rob Landley , Grant Likely , Maxime Ripard , David Woodhouse , linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Brian, On 23/01/2014 02:49, Brian Norris wrote: > + Huang > > Hi Boris, > > On Wed, Jan 08, 2014 at 03:21:56PM +0100, Boris BREZILLON wrote: >> The Hynix nand flashes store their ECC requirements in byte 4 of its id >> (returned on READ ID command). >> >> Signed-off-by: Boris BREZILLON > I haven't verified yet (perhaps Huang can confirm?), but this may be > similar to a patch Huang submitted recently. In his case, we found that > this table is actually quite unreliable and is likely hard to maintain. Indeed (as stated in this thread http://comments.gmane.org/gmane.linux.drivers.mtd/50252). I'll remove this patch from the next version of this series and make use of the nand-ecc-strength /nand-ecc-size DT properties instead. Thanks. Best Regards, Boris > > Why do you need this ECC information, for my reference? > > Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.brezillon@overkiz.com (Boris BREZILLON) Date: Wed, 05 Feb 2014 14:53:25 +0100 Subject: [RFC PATCH 1/9] mtd: nand: retrieve ECC requirements from Hynix READ ID byte 4 In-Reply-To: <20140123014906.GY8919@ld-irv-0074> References: <1389190924-26226-1-git-send-email-b.brezillon@overkiz.com> <1389190924-26226-2-git-send-email-b.brezillon@overkiz.com> <20140123014906.GY8919@ld-irv-0074> Message-ID: <52F24255.9030603@overkiz.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Brian, On 23/01/2014 02:49, Brian Norris wrote: > + Huang > > Hi Boris, > > On Wed, Jan 08, 2014 at 03:21:56PM +0100, Boris BREZILLON wrote: >> The Hynix nand flashes store their ECC requirements in byte 4 of its id >> (returned on READ ID command). >> >> Signed-off-by: Boris BREZILLON > I haven't verified yet (perhaps Huang can confirm?), but this may be > similar to a patch Huang submitted recently. In his case, we found that > this table is actually quite unreliable and is likely hard to maintain. Indeed (as stated in this thread http://comments.gmane.org/gmane.linux.drivers.mtd/50252). I'll remove this patch from the next version of this series and make use of the nand-ecc-strength /nand-ecc-size DT properties instead. Thanks. Best Regards, Boris > > Why do you need this ECC information, for my reference? > > Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris BREZILLON Subject: Re: [RFC PATCH 1/9] mtd: nand: retrieve ECC requirements from Hynix READ ID byte 4 Date: Wed, 05 Feb 2014 14:53:25 +0100 Message-ID: <52F24255.9030603@overkiz.com> References: <1389190924-26226-1-git-send-email-b.brezillon@overkiz.com> <1389190924-26226-2-git-send-email-b.brezillon@overkiz.com> <20140123014906.GY8919@ld-irv-0074> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Return-path: In-Reply-To: <20140123014906.GY8919@ld-irv-0074> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Brian Norris Cc: Maxime Ripard , Rob Landley , Russell King , David Woodhouse , Grant Likely , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Huang Shijie List-Id: devicetree@vger.kernel.org Hello Brian, On 23/01/2014 02:49, Brian Norris wrote: > + Huang > > Hi Boris, > > On Wed, Jan 08, 2014 at 03:21:56PM +0100, Boris BREZILLON wrote: >> The Hynix nand flashes store their ECC requirements in byte 4 of its id >> (returned on READ ID command). >> >> Signed-off-by: Boris BREZILLON > I haven't verified yet (perhaps Huang can confirm?), but this may be > similar to a patch Huang submitted recently. In his case, we found that > this table is actually quite unreliable and is likely hard to maintain. Indeed (as stated in this thread http://comments.gmane.org/gmane.linux.drivers.mtd/50252). I'll remove this patch from the next version of this series and make use of the nand-ecc-strength /nand-ecc-size DT properties instead. Thanks. Best Regards, Boris > > Why do you need this ECC information, for my reference? > > Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbaBENyV (ORCPT ); Wed, 5 Feb 2014 08:54:21 -0500 Received: from 6.mo3.mail-out.ovh.net ([188.165.43.173]:49753 "EHLO mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751835AbaBENyQ (ORCPT ); Wed, 5 Feb 2014 08:54:16 -0500 Message-ID: <52F24255.9030603@overkiz.com> Date: Wed, 05 Feb 2014 14:53:25 +0100 From: Boris BREZILLON User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Brian Norris CC: Maxime Ripard , Rob Landley , Russell King , David Woodhouse , Grant Likely , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, dev@linux-sunxi.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Huang Shijie Subject: Re: [RFC PATCH 1/9] mtd: nand: retrieve ECC requirements from Hynix READ ID byte 4 References: <1389190924-26226-1-git-send-email-b.brezillon@overkiz.com> <1389190924-26226-2-git-send-email-b.brezillon@overkiz.com> <20140123014906.GY8919@ld-irv-0074> In-Reply-To: <20140123014906.GY8919@ld-irv-0074> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 4782541329942673631 X-Ovh-Remote: 80.245.18.66 () X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrjedvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-Spam-Check: DONE|U 0.501258/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrjedvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Brian, On 23/01/2014 02:49, Brian Norris wrote: > + Huang > > Hi Boris, > > On Wed, Jan 08, 2014 at 03:21:56PM +0100, Boris BREZILLON wrote: >> The Hynix nand flashes store their ECC requirements in byte 4 of its id >> (returned on READ ID command). >> >> Signed-off-by: Boris BREZILLON > I haven't verified yet (perhaps Huang can confirm?), but this may be > similar to a patch Huang submitted recently. In his case, we found that > this table is actually quite unreliable and is likely hard to maintain. Indeed (as stated in this thread http://comments.gmane.org/gmane.linux.drivers.mtd/50252). I'll remove this patch from the next version of this series and make use of the nand-ecc-strength /nand-ecc-size DT properties instead. Thanks. Best Regards, Boris > > Why do you need this ECC information, for my reference? > > Brian