From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB4hb-0000cJ-FN for qemu-devel@nongnu.org; Wed, 05 Feb 2014 10:47:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB4hU-0003Qi-5d for qemu-devel@nongnu.org; Wed, 05 Feb 2014 10:47:51 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37212 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB4hT-0003QX-VR for qemu-devel@nongnu.org; Wed, 05 Feb 2014 10:47:44 -0500 Message-ID: <52F25D1C.4020602@suse.de> Date: Wed, 05 Feb 2014 16:47:40 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1389360699-9183-1-git-send-email-armbru@redhat.com> <1389360699-9183-2-git-send-email-armbru@redhat.com> In-Reply-To: <1389360699-9183-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefano Stabellini Cc: Paolo Bonzini , armbru@redhat.com Stefano, Am 10.01.2014 14:31, schrieb armbru@redhat.com: > From: Markus Armbruster >=20 > Get available machines via QMP instead of hardcoding a list that's > perpetually out of date. >=20 > A few machines don't work out of the box: [...] > * Xen machines can work only when running under the Xen hypervisor. >=20 > Blacklist them. >=20 > Signed-off-by: Markus Armbruster > --- > tests/qom-test.c | 283 +++++++++++++----------------------------------= -------- > 1 file changed, 66 insertions(+), 217 deletions(-) >=20 > diff --git a/tests/qom-test.c b/tests/qom-test.c > index 5e5af7a..3cbd480 100644 > --- a/tests/qom-test.c > +++ b/tests/qom-test.c > @@ -11,6 +11,42 @@ > #include > #include > #include "qemu/osdep.h" > +#include "qapi/qmp/types.h" > + [...] > + > +static const char *blacklist_x86[] =3D { > + "xenfv", "xenpv", NULL > +}; [snip] I'm wondering if we could enable these machines conditional to CONFIG_XEN, so I've tried commenting out the two since I have the Xen libraries installed, but I get this: $ make check-qtest V=3D1 [...] /i386/qom/xenpv: xen be core: can't connect to xenstored xen_init_pv: xen backend core setup failed Broken pipe FAIL [...] /i386/qom/xenfv: Broken pipe FAIL [...] Have you checked whether you can make some code dependent on !qtest_enabled() to make your machines testable by non-Xen users? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg