From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB62a-0008Kw-HC for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:13:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB62T-00005M-5e for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:13:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38935 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB62S-000052-V3 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:13:29 -0500 Message-ID: <52F27134.9030203@suse.de> Date: Wed, 05 Feb 2014 18:13:24 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1391087394-17914-1-git-send-email-pbonzini@redhat.com> <1391087394-17914-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1391087394-17914-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com, Luiz Capitulino Am 30.01.2014 14:09, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > qapi/string-input-visitor.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index 8f1bc41..793548a 100644 > --- a/qapi/string-input-visitor.c > +++ b/qapi/string-input-visitor.c > @@ -14,6 +14,7 @@ > #include "qapi/string-input-visitor.h" > #include "qapi/visitor-impl.h" > #include "qapi/qmp/qerror.h" > +#include "qemu/option.h" > =20 > struct StringInputVisitor > { > @@ -41,6 +42,28 @@ static void parse_type_int(Visitor *v, int64_t *obj,= const char *name, > *obj =3D val; > } > =20 > +static void parse_type_size(Visitor *v, uint64_t *obj, const char *nam= e, > + Error **errp) > +{ > + StringInputVisitor *siv =3D DO_UPCAST(StringInputVisitor, visitor,= v); > + Error *err =3D NULL; > + uint64_t val; > + > + if (siv->string) { > + parse_option_size(name, siv->string, &val, &err); > + } else { > + error_set(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "nu= ll", > + "size"); error_setg()? Otherwise looks fine. CC'ing Luiz. Andreas > + return; > + } > + if (err) { > + error_propagate(errp, err); > + return; > + } > + > + *obj =3D val; > +} > + > static void parse_type_bool(Visitor *v, bool *obj, const char *name, > Error **errp) > { > @@ -128,6 +151,7 @@ StringInputVisitor *string_input_visitor_new(const = char *str) > =20 > v->visitor.type_enum =3D input_type_enum; > v->visitor.type_int =3D parse_type_int; > + v->visitor.type_size =3D parse_type_size; > v->visitor.type_bool =3D parse_type_bool; > v->visitor.type_str =3D parse_type_str; > v->visitor.type_number =3D parse_type_number; >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg