From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB6n2-0005dd-4f for qemu-devel@nongnu.org; Wed, 05 Feb 2014 13:01:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB6n1-0001Id-9A for qemu-devel@nongnu.org; Wed, 05 Feb 2014 13:01:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40098 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB6n1-0001IZ-2w for qemu-devel@nongnu.org; Wed, 05 Feb 2014 13:01:35 -0500 Message-ID: <52F27C7A.2040701@suse.de> Date: Wed, 05 Feb 2014 19:01:30 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1391621709-15620-1-git-send-email-afaerber@suse.de> <52F2795D.10708@redhat.com> <52F27A1D.2040504@suse.de> <52F27B1C.6010307@redhat.com> In-Reply-To: <52F27B1C.6010307@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] scripts: Add qom-tree script as modern equivalent of info qtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, armbru@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com Am 05.02.2014 18:55, schrieb Paolo Bonzini: > Il 05/02/2014 18:51, Andreas F=C3=A4rber ha scritto: >>> > So, even though I think this script is a very welcome addition, I >>> don't >>> > think it helps settling the question of what to do with "info qtree= ". >>> > IMO there's no good reason to exclude busless devices from "info >>> qtree", >>> > and it's a bug (of course less severe than crashing, but still a bu= g) >>> > that the busless nand device doesn't appear there. >> Don't you see that that is unfixable? We may be able to replace info >> qtree by an info qom-tree, which does the equivalent of this QMP-based >> script, but qtree ues a completely different display hierarchy than QO= M. >=20 > Yes, that's why it's useful. :) >=20 > Busless devices can still be listed, either under their parent or as > siblings of the system bus. info qtree has been inconclusive for - what? - two years now and no one has bothered to fix it. If you or Markus care about it, post a patch. :) The code uses qdev/qbus functions to list those devices so I don't see an easy way of filtering those devices that qdev/qbus missed and printing them using the same walking functions. Therefore my saying that we would need to walk the QOM hierarchy instead, which is output-incompatible with info qtree and thus a different command. Not to mention that it will not work for objects that are not devices. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg