All of lore.kernel.org
 help / color / mirror / Atom feed
From: Satish Patel <satish.patel@ti.com>
To: Roger Quadros <rogerq@ti.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
	rob@landley.net
Subject: Re: [PATCH v2 3/5] char: ti-usim: Add driver for USIM module on AM43xx
Date: Thu, 6 Feb 2014 09:16:24 +0530	[thread overview]
Message-ID: <52F30590.1020802@ti.com> (raw)
In-Reply-To: <52F0E8EC.8030900@ti.com>



On 2/4/2014 6:49 PM, Roger Quadros wrote:
> Hi Satish,
> 
> On 01/20/2014 06:33 AM, Satish Patel wrote:
>> TI-USIM driver is a platform driver that provides a character
>> driver interface to user applications.
>>
>> It allows user applications to call IOCTL's to
>> perform smart card operations.
>>
>> Driver currently supports
>> - ATR
>> - T=0 & T=1 protocol
>> - clock stop mode
>> - smart card clock configuration
>> - Tx/Rx application data units (APDU) to smart card
>> - Interface to PHY using DT & phy interface
>>
>> Validation is done with ACOS3 smart cards
>>
>> Signed-off-by: Satish Patel <satish.patel@ti.com>
>> ---
>>  .../devicetree/bindings/ti-usim/ti-usim.txt        |   31 +
>>  drivers/char/Kconfig                               |    7 +
>>  drivers/char/Makefile                              |    1 +
>>  drivers/char/ti-usim-hw.h                          |  863 +++++++++
>>  drivers/char/ti-usim.c                             | 1859 ++++++++++++++++++++
> 
> ti-usim.c is a very large driver that does everything but looks like limited to TI hardware.
> How about splitting it into generic stuff and hw specific glue logic so that most of the generic stuff
> could be used by different hardware types.
> 
Two things over here
- First interface between user application and smartcard controller
driver. There is already an open source f/w in user space called "pcsc"
exists for this.

- Second communication between smartcard controller and smartcard phy. I
have introduce lite interface called sc_phy which covers generic stuff
between controller and phy.


>>  include/linux/ti-usim.h                            |   98 +
>>  6 files changed, 2859 insertions(+), 0 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/ti-usim/ti-usim.txt
>>  create mode 100644 drivers/char/ti-usim-hw.h
>>  create mode 100644 drivers/char/ti-usim.c
>>  create mode 100644 include/linux/ti-usim.h
>>
> 
> cheers,
> -roger
> 

WARNING: multiple messages have this Message-ID (diff)
From: satish.patel@ti.com (Satish Patel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] char: ti-usim: Add driver for USIM module on AM43xx
Date: Thu, 6 Feb 2014 09:16:24 +0530	[thread overview]
Message-ID: <52F30590.1020802@ti.com> (raw)
In-Reply-To: <52F0E8EC.8030900@ti.com>



On 2/4/2014 6:49 PM, Roger Quadros wrote:
> Hi Satish,
> 
> On 01/20/2014 06:33 AM, Satish Patel wrote:
>> TI-USIM driver is a platform driver that provides a character
>> driver interface to user applications.
>>
>> It allows user applications to call IOCTL's to
>> perform smart card operations.
>>
>> Driver currently supports
>> - ATR
>> - T=0 & T=1 protocol
>> - clock stop mode
>> - smart card clock configuration
>> - Tx/Rx application data units (APDU) to smart card
>> - Interface to PHY using DT & phy interface
>>
>> Validation is done with ACOS3 smart cards
>>
>> Signed-off-by: Satish Patel <satish.patel@ti.com>
>> ---
>>  .../devicetree/bindings/ti-usim/ti-usim.txt        |   31 +
>>  drivers/char/Kconfig                               |    7 +
>>  drivers/char/Makefile                              |    1 +
>>  drivers/char/ti-usim-hw.h                          |  863 +++++++++
>>  drivers/char/ti-usim.c                             | 1859 ++++++++++++++++++++
> 
> ti-usim.c is a very large driver that does everything but looks like limited to TI hardware.
> How about splitting it into generic stuff and hw specific glue logic so that most of the generic stuff
> could be used by different hardware types.
> 
Two things over here
- First interface between user application and smartcard controller
driver. There is already an open source f/w in user space called "pcsc"
exists for this.

- Second communication between smartcard controller and smartcard phy. I
have introduce lite interface called sc_phy which covers generic stuff
between controller and phy.


>>  include/linux/ti-usim.h                            |   98 +
>>  6 files changed, 2859 insertions(+), 0 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/ti-usim/ti-usim.txt
>>  create mode 100644 drivers/char/ti-usim-hw.h
>>  create mode 100644 drivers/char/ti-usim.c
>>  create mode 100644 include/linux/ti-usim.h
>>
> 
> cheers,
> -roger
> 

WARNING: multiple messages have this Message-ID (diff)
From: Satish Patel <satish.patel@ti.com>
To: Roger Quadros <rogerq@ti.com>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<gregkh@linuxfoundation.org>, <rob@landley.net>
Subject: Re: [PATCH v2 3/5] char: ti-usim: Add driver for USIM module on AM43xx
Date: Thu, 6 Feb 2014 09:16:24 +0530	[thread overview]
Message-ID: <52F30590.1020802@ti.com> (raw)
In-Reply-To: <52F0E8EC.8030900@ti.com>



On 2/4/2014 6:49 PM, Roger Quadros wrote:
> Hi Satish,
> 
> On 01/20/2014 06:33 AM, Satish Patel wrote:
>> TI-USIM driver is a platform driver that provides a character
>> driver interface to user applications.
>>
>> It allows user applications to call IOCTL's to
>> perform smart card operations.
>>
>> Driver currently supports
>> - ATR
>> - T=0 & T=1 protocol
>> - clock stop mode
>> - smart card clock configuration
>> - Tx/Rx application data units (APDU) to smart card
>> - Interface to PHY using DT & phy interface
>>
>> Validation is done with ACOS3 smart cards
>>
>> Signed-off-by: Satish Patel <satish.patel@ti.com>
>> ---
>>  .../devicetree/bindings/ti-usim/ti-usim.txt        |   31 +
>>  drivers/char/Kconfig                               |    7 +
>>  drivers/char/Makefile                              |    1 +
>>  drivers/char/ti-usim-hw.h                          |  863 +++++++++
>>  drivers/char/ti-usim.c                             | 1859 ++++++++++++++++++++
> 
> ti-usim.c is a very large driver that does everything but looks like limited to TI hardware.
> How about splitting it into generic stuff and hw specific glue logic so that most of the generic stuff
> could be used by different hardware types.
> 
Two things over here
- First interface between user application and smartcard controller
driver. There is already an open source f/w in user space called "pcsc"
exists for this.

- Second communication between smartcard controller and smartcard phy. I
have introduce lite interface called sc_phy which covers generic stuff
between controller and phy.


>>  include/linux/ti-usim.h                            |   98 +
>>  6 files changed, 2859 insertions(+), 0 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/ti-usim/ti-usim.txt
>>  create mode 100644 drivers/char/ti-usim-hw.h
>>  create mode 100644 drivers/char/ti-usim.c
>>  create mode 100644 include/linux/ti-usim.h
>>
> 
> cheers,
> -roger
> 

  reply	other threads:[~2014-02-06  3:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20  4:33 [PATCH v2 0/5] Smart Card(SC) interface, TI USIM & NxP SC phy driver Satish Patel
2014-01-20  4:33 ` Satish Patel
2014-01-20  4:33 ` Satish Patel
2014-01-20  4:33 ` [PATCH v2 1/5] sc_phy:SmartCard(SC) PHY interface to SC controller Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33 ` [PATCH v2 2/5] misc: tda8026: Add NXP TDA8026 PHY driver Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33 ` [PATCH v2 3/5] char: ti-usim: Add driver for USIM module on AM43xx Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33   ` Satish Patel
     [not found]   ` <1390192434-19386-4-git-send-email-satish.patel-l0cyMroinI0@public.gmane.org>
2014-02-04 13:19     ` Roger Quadros
2014-02-04 13:19       ` Roger Quadros
2014-02-04 13:19       ` Roger Quadros
2014-02-06  3:46       ` Satish Patel [this message]
2014-02-06  3:46         ` Satish Patel
2014-02-06  3:46         ` Satish Patel
2014-01-20  4:33 ` [PATCH v2 4/5] ARM: dts: AM43xx: DT entries added for ti-usim Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33 ` [PATCH v2 5/5] ARM: dts: AM43xx-epos-evm: DT entries for ti-usim and phy Satish Patel
2014-01-20  4:33   ` Satish Patel
2014-01-20  4:33   ` Satish Patel
     [not found] ` <1390192434-19386-1-git-send-email-satish.patel-l0cyMroinI0@public.gmane.org>
2014-01-30  5:52   ` [PATCH v2 0/5] Smart Card(SC) interface, TI USIM & NxP SC phy driver Satish Patel
2014-01-30  5:52     ` Satish Patel
2014-01-30  5:52     ` Satish Patel
     [not found]     ` <52E9E8B0.2020000-l0cyMroinI0@public.gmane.org>
2014-01-30 13:05       ` Greg KH
2014-01-30 13:05         ` Greg KH
2014-01-30 13:05         ` Greg KH
2014-05-16  3:44         ` Satish Patel
2014-05-16  3:44           ` Satish Patel
2014-05-16  3:44           ` Satish Patel
2014-05-28  0:41           ` Greg KH
2014-05-28  0:41             ` Greg KH
2014-05-28  9:00             ` Satish Patel
2014-05-28  9:00               ` Satish Patel
2014-05-28  9:00               ` Satish Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F30590.1020802@ti.com \
    --to=satish.patel@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.