All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: linux-watchdog@vger.kernel.org, vasily.isaenko@oracle.com
Subject: Re: [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found
Date: Wed, 05 Feb 2014 23:25:31 -0800	[thread overview]
Message-ID: <52F338EB.2070702@roeck-us.net> (raw)
In-Reply-To: <52F32AD8.4010108@oracle.com>

On 02/05/2014 10:25 PM, Stanislav Kholmanskikh wrote:
> Hi!
>
> On 01/27/2014 08:33 PM, Guenter Roeck wrote:
>> On Mon, Jan 27, 2014 at 11:04:33AM +0400, Stanislav Kholmanskikh wrote:
>>> Most WDT driver modules return ENODEV during modprobe if
>>> no valid device was found, but w83697hf_wdt returns EIO.
>>>
>>> Let w83697hf_wdt return ENODEV.
>>>
>>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Thank you.
>
> I'm a newbie here.
>
> Should I do something to move it forward (like send this to an another mail list), or just wait? :)
>

Just wait. I'll apply it to my tree and send a reminder to Wim at some point.
Usually Wim is pretty good at picking things up himself, though.

Of course, fun part in this case is that I actually submitted a patch
to remove this driver ;-). Not as bad as it sounds - reason was that
the w83627hf driver now supports the w83697hf as well, and the w83697hf
driver is thus redundant. I can understand Wim if he wants to keep
the driver around for a while, though.

Guenter


  reply	other threads:[~2014-02-06  7:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27  7:04 [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found Stanislav Kholmanskikh
2014-01-27 16:33 ` Guenter Roeck
2014-02-06  6:25   ` Stanislav Kholmanskikh
2014-02-06  7:25     ` Guenter Roeck [this message]
2014-02-06  7:49       ` Stanislav Kholmanskikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F338EB.2070702@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=stanislav.kholmanskikh@oracle.com \
    --cc=vasily.isaenko@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.