From: Stefano Babic <sbabic@denx.de>
To: Jingoo Han <jg1.han@samsung.com>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, "'Stefano Babic'" <sbabic@denx.de>,
"'Anatolij Gustschin'" <agust@denx.de>
Subject: Re: [PATCH 06/12] backlight: ili922x: Remove unnecessary OOM messages
Date: Thu, 06 Feb 2014 10:15:16 +0100 [thread overview]
Message-ID: <52F352A4.7090500@denx.de> (raw)
In-Reply-To: <000701cf2314$78459d60$68d0d820$%han@samsung.com>
Hi Jingoo,
On 06/02/2014 09:21, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/ili922x.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index 73464e4..ea67fe1 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -482,10 +482,8 @@ static int ili922x_probe(struct spi_device *spi)
> u16 reg = 0;
>
> ili = devm_kzalloc(&spi->dev, sizeof(*ili), GFP_KERNEL);
> - if (!ili) {
> - dev_err(&spi->dev, "cannot alloc priv data\n");
> + if (!ili)
> return -ENOMEM;
> - }
>
> ili->spi = spi;
> spi_set_drvdata(spi, ili);
>
Acked-by: Stefano Babic <sbabic@denx.de>
Thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
next prev parent reply other threads:[~2014-02-06 9:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 8:14 [PATCH 00/12] backlight: Remove unnecessary OOM messages Jingoo Han
2014-02-06 8:16 ` [PATCH 01/12] backlight: aat2870: " Jingoo Han
2014-02-07 6:18 ` jinyoungp
2014-02-06 8:16 ` [PATCH 02/12] backlight: adp8860: " Jingoo Han
2014-02-06 8:17 ` [PATCH 03/12] backlight: adp8870: " Jingoo Han
2014-02-06 10:42 ` Michael Hennerich
2014-02-06 8:19 ` [PATCH 04/12] backlight: corgi_lcd: " Jingoo Han
2014-02-06 8:20 ` [PATCH 05/12] backlight: hx8357: " Jingoo Han
2014-02-06 8:31 ` 'Maxime Ripard'
2014-02-06 8:21 ` [PATCH 06/12] backlight: ili922x: " Jingoo Han
2014-02-06 9:15 ` Stefano Babic [this message]
2014-02-06 8:22 ` [PATCH 07/12] backlight: ili9320: " Jingoo Han
2014-02-06 8:24 ` [PATCH 08/12] backlight: l4f00242t03: " Jingoo Han
2014-02-06 8:25 ` [PATCH 09/12] backlight: lm3533_bl: " Jingoo Han
2014-02-06 16:06 ` 'Johan Hovold'
2014-02-06 8:26 ` [PATCH 10/12] backlight: lms283gf05: " Jingoo Han
2014-02-06 13:34 ` Marek Vasut
2014-02-06 8:31 ` [PATCH 11/12] backlight: platform_lcd: " Jingoo Han
2014-02-06 8:32 ` [PATCH 12/12] backlight: tps65217_bl: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F352A4.7090500@denx.de \
--to=sbabic@denx.de \
--cc=agust@denx.de \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.